This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Respect compute ABI attributes with unknown OS
ClosedPublic

Authored by arsenm on Aug 13 2021, 7:13 AM.

Details

Summary

Unfortunately Mesa is still using amdgcn-- as the triple for OpenGL,
so we still have the awkward unknown OS case to deal with. Previously
if the HSA ABI intrinsics appeared, we we would not add the ABI
registers to the function. We would emit an error later, but we still
need to produce some compile result. Start adding the registers to any
compute function, regardless of the OS. This keeps the internal state
more consistent, and will help avoid numerous test crashes in a future
patch which starts assuming the ABI inputs are present on functions by
default.

Diff Detail

Event Timeline

arsenm created this revision.Aug 13 2021, 7:13 AM
arsenm requested review of this revision.Aug 13 2021, 7:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2021, 7:13 AM
Herald added a subscriber: wdng. · View Herald Transcript
rampitec accepted this revision.Aug 13 2021, 9:54 AM
This revision is now accepted and ready to land.Aug 13 2021, 9:54 AM