This is an archive of the discontinued LLVM Phabricator instance.

Differential D107922

[lld-macho] Fill out release notes for 13.x
ClosedPublic

Authored by int3 on Aug 11 2021, 12:19 PM.

Details

Reviewers
tstellar
MaskRay
oontvoo
Group Reviewers
Restricted Project
Summary

I probably missed out some things, given how much work was done in the
last few months...

Diff Detail

Event Timeline

int3 created this revision.Aug 11 2021, 12:19 PM
Herald added a reviewer: MaskRay. · View Herald TranscriptAug 11 2021, 12:19 PM
int3 requested review of this revision.Aug 11 2021, 12:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2021, 12:19 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
smeenai added a subscriber: smeenai.Aug 11 2021, 12:25 PM
smeenai added inline comments.
lld/docs/ReleaseNotes.rst
62

We added --icf=all, not --icf=safe, right?

66

We support $ld$previous as well now, I thought.

oontvoo accepted this revision.Aug 11 2021, 12:38 PM
oontvoo added a subscriber: oontvoo.

Nice! thanks

lld/docs/ReleaseNotes.rst
56

the phrase seems a bit comical to me :) ...

67

"emitted properly" ?

This revision is now accepted and ready to land.Aug 11 2021, 12:38 PM
int3 updated this revision to Diff 365822.Aug 11 2021, 12:42 PM

address comments

int3 marked an inline comment as done.Aug 11 2021, 12:43 PM
int3 added inline comments.
lld/docs/ReleaseNotes.rst
62

oops. I was under the impression that safe and all were currently equivalent, but I see now that safe gets changed to none.

66

yeah, missed that one

int3 marked an inline comment as done.Aug 11 2021, 12:44 PM
int3 added inline comments.
lld/docs/ReleaseNotes.rst
56

it's a common turn of phrase... I think

67

I considered that, but only __mh_execute_header is actually emitted...

oontvoo added inline comments.Aug 11 2021, 12:48 PM
lld/docs/ReleaseNotes.rst
89

-map https://reviews.llvm.org/D98323 ?

int3 updated this revision to Diff 365827.Aug 11 2021, 12:54 PM
int3 marked an inline comment as done.Aug 11 2021, 12:55 PM
int3 added inline comments.
lld/docs/ReleaseNotes.rst
89

good catch. I'll mark it as 'partially supported' since the output file is still missing some info (per https://bugs.llvm.org/show_bug.cgi?id=50689)

Harbormaster completed remote builds in B119130: Diff 365827.Aug 11 2021, 1:53 PM
thevinster added a subscriber: thevinster.Aug 13 2021, 2:03 AM
thevinster removed a subscriber: thevinster.
int3 closed this revision.Aug 16 2021, 10:36 AM
int3 marked an inline comment as done.

Closed by https://github.com/llvm/llvm-project/commit/1bbe8ef81549b37d2c74cfb607cffe0e01ab4dd3

Revision Contents

PathSize
lld/
docs/
49 lines

Diff 365827

lld/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
* ... * ...
MinGW Improvements MinGW Improvements
------------------ ------------------
* ... * ...
MachO Improvements Mach-O Improvements
------------------ -------------------
The Mach-O backend is now able to link several large, real-world programs,
though we are still working out the kinks.
oontvooUnsubmitted
Done
ReplyInline Actions

the phrase seems a bit comical to me :) ...

oontvoo: the phrase seems a bit comical to me :) ...
int3AuthorUnsubmitted
Done
ReplyInline Actions

it's a common turn of phrase... I think

int3: it's a common turn of phrase... I think
* arm64 is now supported as a target. (`D88629 <https://reviews.llvm.org/D88629>`_)
* arm64_32 is now supported as a target. (`D99822 <https://reviews.llvm.org/D99822>`_)
* Branch-range-extension thunks are now supported. (`D100818 <https://reviews.llvm.org/D100818>`_)
* ``-dead_strip`` is now supported. (`D103324 <https://reviews.llvm.org/D103324>`_)
* Support for identical code folding (``--icf=all``) has been added.
smeenaiUnsubmitted
Not Done
ReplyInline Actions

We added --icf=all, not --icf=safe, right?

smeenai: We added `--icf=all`, not `--icf=safe`, right?
int3AuthorUnsubmitted
Done
ReplyInline Actions

oops. I was under the impression that safe and all were currently equivalent, but I see now that safe gets changed to none.

int3: oops. I was under the impression that `safe` and `all` were currently equivalent, but I see now…
(`D103292 <https://reviews.llvm.org/D103292>`_)
* Support for special ``$start`` and ``$end`` symbols for segment & sections has been
added. (`D106767 <https://reviews.llvm.org/D106767>`_, `D106629 <https://reviews.llvm.org/D106629>`_)
* ``$ld$previous`` symbols are now supported. (`D103505 <https://reviews.llvm.org/D103505 >`_)
smeenaiUnsubmitted
Done
ReplyInline Actions

We support $ld$previous as well now, I thought.

smeenai: We support `$ld$previous` as well now, I thought.
int3AuthorUnsubmitted
Done
ReplyInline Actions

yeah, missed that one

int3: yeah, missed that one
* ``$ld$install_name`` symbols are now supported. (`D103746 <https://reviews.llvm.org/D103746>`_)
oontvooUnsubmitted
Not Done
ReplyInline Actions

"emitted properly" ?

oontvoo: "emitted properly" ?
int3AuthorUnsubmitted
Done
ReplyInline Actions

I considered that, but only __mh_execute_header is actually emitted...

int3: I considered that, but only `__mh_execute_header` is actually emitted...
* ``__mh_*_header`` symbols are now supported. (`D97007 <https://reviews.llvm.org/D97007>`_)
* LC_CODE_SIGNATURE is now supported. (`D96164 <https://reviews.llvm.org/D96164>`_)
* LC_FUNCTION_STARTS is now supported. (`D97260 <https://reviews.llvm.org/D97260>`_)
* LC_DATA_IN_CODE is now supported. (`D103006 <https://reviews.llvm.org/D103006>`_)
* Bind opcodes are more compactly encoded. (`D106128 <https://reviews.llvm.org/D106128>`_,
`D105075 <https://reviews.llvm.org/D105075>`_)
* LTO cache support has been added. (`D105922 <https://reviews.llvm.org/D105922>`_)
* ``-application_extension`` is now supported. (`D105818 <https://reviews.llvm.org/D105818>`_)
* ``-export_dynamic`` is now partially supported. (`D105482 <https://reviews.llvm.org/D105482>`_)
* ``-arch_multiple`` is now supported. (`D105450 <https://reviews.llvm.org/D105450>`_)
* ``-final_output`` is now supported. (`D105449 <https://reviews.llvm.org/D105449>`_)
* ``-umbrella`` is now supported. (`D105448 <https://reviews.llvm.org/D105448>`_)
* ``--print-dylib-search`` is now supported. (`D103985 <https://reviews.llvm.org/D103985>`_)
* ``-force_load_swift_libs`` is now supported. (`D103709 <https://reviews.llvm.org/D103709>`_)
* ``-reexport_framework``, ``-reexport_library``, ``-reexport-l`` are now supported.
(`D103497 <https://reviews.llvm.org/D103497>`_)
* ``.weak_def_can_be_hidden`` is now supported. (`D101080 <https://reviews.llvm.org/D101080>`_)
* ``-add_ast_path`` is now supported. (`D100076 <https://reviews.llvm.org/D100076>`_)
* ``-segprot`` is now supported. (`D99389 <https://reviews.llvm.org/D99389>`_)
* ``-dependency_info`` is now partially supported. (`D98559 <https://reviews.llvm.org/D98559>`_)
* ``--time-trace`` is now supported. (`D98419 <https://reviews.llvm.org/D98419>`_)
* ``-mark_dead_strippable_dylib`` is now supported. (`D98262 <https://reviews.llvm.org/D98262>`_)
oontvooUnsubmitted
Done
ReplyInline Actions

-map https://reviews.llvm.org/D98323 ?

oontvoo: -map https://reviews.llvm.org/D98323 ?
int3AuthorUnsubmitted
Done
ReplyInline Actions

good catch. I'll mark it as 'partially supported' since the output file is still missing some info (per https://bugs.llvm.org/show_bug.cgi?id=50689)

int3: good catch. I'll mark it as 'partially supported' since the output file is still missing some…
* ``-[un]exported_symbol[s_list]`` is now supported. (`D98223 <https://reviews.llvm.org/D98223>`_)
* ``-flat_namespace`` is now supported. (`D97641 <https://reviews.llvm.org/D97641>`_)
* ``-rename_section`` and ``-rename_segment`` are now supported. (`D97600 <https://reviews.llvm.org/D97600>`_)
* ``-bundle_loader`` is now supported. (`D95913 <https://reviews.llvm.org/D95913>`_)
* ``-map`` is now partially supported. (`D98323 <https://reviews.llvm.org/D98323>`_)
* Item 1. There were numerous other bug-fixes as well.
WebAssembly Improvements WebAssembly Improvements
------------------------ ------------------------