<type_traits> was included in the first iteration of <compare> when it was created as a monolithic header, then never removed. Removing it now is a beneficial no-op since it is not guaranteed by the standard and is already included by all of its subheaders.
Details
Details
- Reviewers
ldionne Mordante zoecarver cjdb • Quuxplusone - Group Reviewers
Restricted Project - Commits
- rG7e325d4c0c2f: [libc++][NFC] Remove unused include in <compare>.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Sure, LGTM. For pre-C++20 headers I believe we still don't want to remove #includes this way, because someone in the wild might be relying on the #include. But for C++20 <compare> (and C++20 <concepts> we're going ahead and doing this, AFAIK.
libcxx/CREDITS.TXT | ||
---|---|---|
160–163 | If you're trying to alphabetize the contributor list, this is laughably insufficient. ;) I recommend reverting this diff, but it doesn't really matter AFAIC. |
libcxx/CREDITS.TXT | ||
---|---|---|
160–163 | oh no, hahaha... i'll leave this as-is to grease the rails and fix the other misalphabetization in another diff later. |
If you're trying to alphabetize the contributor list, this is laughably insufficient. ;) I recommend reverting this diff, but it doesn't really matter AFAIC.