This is an archive of the discontinued LLVM Phabricator instance.

Set supported target for asan-use-callbacks test
ClosedPublic

Authored by thopre on Aug 6 2021, 3:13 AM.

Details

Summary

Explicitely set x86_64-linux-gnu as a target for asan-use-callbacks
clang test since some target do not support -fsanitize=address (e.g.
i386-pc-openbsd). Also remove redundant -fsanitize=address and move
-emit-llvm right after -S.

Diff Detail

Event Timeline

thopre created this revision.Aug 6 2021, 3:13 AM
thopre requested review of this revision.Aug 6 2021, 3:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2021, 3:13 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
vitalybuka accepted this revision.Aug 9 2021, 11:29 AM
This revision is now accepted and ready to land.Aug 9 2021, 11:29 AM
vitalybuka requested changes to this revision.Aug 9 2021, 11:30 AM
This revision now requires changes to proceed.Aug 9 2021, 11:30 AM

Why other tests, like CodeGen/asan-strings.c do not need REQUIRES: ?

vitalybuka accepted this revision.Aug 9 2021, 11:34 AM

All but line 1 is LGTM
Line 1 is probably not needed, but I don't know why.

This revision is now accepted and ready to land.Aug 9 2021, 11:34 AM
thopre updated this revision to Diff 365465.Aug 10 2021, 7:01 AM

Remove REQUIRES

This revision was landed with ongoing or failed builds.Aug 10 2021, 7:01 AM
This revision was automatically updated to reflect the committed changes.