Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D107610

[AVR][clang] Pass '-fno-use-init-array' to cc1
ClosedPublic
Actions

Authored by mhjacobson on Aug 5 2021, 4:05 PM.

Details

Reviewers
benshi001
MaskRay
dylanmckay
Commits
rGdae7adda9499: [AVR][clang] Pass '-fno-use-init-array' to cc1 as default
Summary

On AVR, .ctors is used, not .init_array. Make this the default unless specifically overridden by driver argument.

This matches gcc, and it matches the behavior in (e.g.) the NetBSD driver (for certain OS variants).

Diff Detail

Event Timeline

mhjacobson created this revision.Aug 5 2021, 4:05 PM
Herald added subscribers: Jim, krytarowski. · View Herald TranscriptAug 5 2021, 4:05 PM
mhjacobson requested review of this revision.Aug 5 2021, 4:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2021, 4:05 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B118287: Diff 364644.Aug 5 2021, 4:40 PM
MaskRay accepted this revision.Aug 5 2021, 4:47 PM

Looks great!

This revision is now accepted and ready to land.Aug 5 2021, 4:47 PM
Closed by commit rGdae7adda9499: [AVR][clang] Pass '-fno-use-init-array' to cc1 as default (authored by mhjacobson, committed by benshi001). · Explain WhyAug 5 2021, 7:14 PM
This revision was automatically updated to reflect the committed changes.
benshi001 added a commit: rGdae7adda9499: [AVR][clang] Pass '-fno-use-init-array' to cc1 as default.
mhjacobson added a comment.Aug 5 2021, 7:30 PM

Thanks!

Revision Contents
Changeset List

PathSize
clang/
lib/
Driver/
ToolChains/
7 lines
10 lines
test/
Driver/
2 lines

Diff 364674

View Options

clang/lib/Driver/ToolChains/AVR.h

Loading...
View Options

clang/lib/Driver/ToolChains/AVR.cpp

Loading...
View Options

clang/test/Driver/avr-toolchain.c

Loading...