- User Since
- Jul 27 2021, 12:05 AM (80 w, 5 h)
Nov 18 2022
Nov 17 2022
Make the tests play nice with Windows path separators.
Fix a couple warnings.
Test for more paths; test C++.
Nov 16 2022
Nov 9 2022
Oct 24 2022
Hello, and sorry for the delay.
Oct 23 2022
Aug 9 2022
Aug 4 2022
Jan 9 2022
Happy new year! If this change is acceptable, could someone please merge it for me? (And if not, could someone point out what needs more work?) Thanks for your help!
Dec 2 2021
Well, I'm hoping it doesn't prove to be too much work. 🙂 With this fix and D112049, most things are working quite well, though I'm sure I'll uncover more interesting things as I go.
Nov 30 2021
Ping. Is there anyone more suited to reviewing this patch?
Oct 19 2021
The test is failing for a different reason (that I'd forgotten I worked around locally). I'll look into fixing that first. Sorry for noise.
Oct 18 2021
Sep 21 2021
Sep 4 2021
Aug 12 2021
Do we happen to know what change(s) made this pass work correctly for AVR?
Aug 9 2021
Rebase atop recent changes; use separate check lines and string substitution for SYSROOT.
Aug 7 2021
For other examples of using four ..s, look in Gnu.cpp, where there are several places where getParentLibPath() is appended with /../. AddMultilibPaths(), PushPPaths().
Aug 6 2021
I'm also tempted to remove /usr/lib/avr, because these paths make no sense to me: $SYSROOT/usr/lib/avr/lib and $SYSROOT/usr/lib/avr/include.
Aug 5 2021
Aug 4 2021
Appeased the linter.
Aug 3 2021
Move emission of __do_copy_data and __do_clear_bss into AVRAsmPrinter. (Leave AVRTargetStreamer as base class of AVRELFStreamer.)
@MaskRay, do you have an opinion on whether I should move the other undefined-symbols definitions into AVRAsmPrinter.cpp to match?
Removed incorrect use of setExternal().
Aug 1 2021
Just brainstorming. Another option might be to move the code in AVRTargetStreamer::finish() into a new override AVRAsmPrinter::doFinalization(). That would make it so that both bits of .globl code are in AVRAsmPrinter.
Sure, I'm open to that.
Jul 31 2021
Conform to source formatting convention.
Jul 30 2021
You're right, AVR does have a section (.ctors) for the *table* of constructors. But there has to be some code that actually calls the functions in that table. That's what __do_global_ctors does. When present, it gets linked into the boot path (after things like __do_copy_data and __do_clear_bss) to do its work. But if nothing requests it, it won't be linked, and the constructor table will just sit around, never to be consulted.
Add assembly comment.
Fix the ordering of the directives in the test, so that it actually passes! :)
Argh, the test fails now, because the ordering is wrong. Fixing it now.
Fixed alphabetization of includes.
Updated test with update_llc_test_checks.py. Note that update_llc_test_checks.py doesn't actually support AVR at the moment! I had to apply this fix first:
Added a test.
Jul 29 2021
I roughly followed the example of how __do_copy_data and __do_clear_bss are linked, in AVRTargetStreamer::finish().
Thanks, Ben. Yes, would you mind to land the patch for me? Name and e-mail are
Jul 27 2021
Explicitly added --start-group and --end-group to the expectation in the test.
Updated the diff to add more context.
Modified regression test Driver/avr-ld.c to account for the new arguments.