This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] provide strictfp attributes in test file
ClosedPublic

Authored by simonwallis2 on Aug 5 2021, 6:36 AM.

Details

Summary

A post-commit review comment on https://reviews.llvm.org/D107452 pointed out that
https://llvm.org/docs/LangRef.html
says:
"In a function that uses the constrained intrinsics the strictfp attribute is required on all function calls."

Although there are several files across several test directories which don't follow this guidance, it is straightforward to provide this attribute.

Diff Detail

Event Timeline

simonwallis2 created this revision.Aug 5 2021, 6:36 AM
simonwallis2 requested review of this revision.Aug 5 2021, 6:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2021, 6:36 AM
kpn accepted this revision.Aug 23 2021, 9:23 AM

Not sure how I missed this. Sorry about that.

LGTM.

This revision is now accepted and ready to land.Aug 23 2021, 9:23 AM
This revision was automatically updated to reflect the committed changes.