User Details
User Details
- User Since
- Jan 22 2020, 8:14 AM (176 w, 1 d)
Wed, May 31
Wed, May 31
Thu, May 25
Thu, May 25
simonwallis2 added inline comments to D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM.
May 2 2023
May 2 2023
simonwallis2 added inline comments to D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM.
simonwallis2 added inline comments to D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections.
simonwallis2 added inline comments to D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections.
Apr 11 2023
Apr 11 2023
Apr 11 2023, 12:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Mar 30 2023
Mar 30 2023
Herald added a reviewer for D129506: Move instruction predicate verification to emitInstruction: mpaszkowski.
Mar 15 2023
Mar 15 2023
simonwallis2 added a comment to D125807: [ConstantFolding] Pre-commit tests showing denormal handling during folding.
I'm not sure what is the right protocol for adding review comments to a long-submitted patch.
But, whilst thinking of adding float16 tests, I noticed 4 possible inconsistencies in float32 tests.
Aug 31 2021
Aug 31 2021
simonwallis2 committed rGf417b660eefd: [Arm] Add assert in T2 Imm7s code emitter (authored by simonwallis2).
[Arm] Add assert in T2 Imm7s code emitter
Aug 31 2021, 12:17 AM · Restricted Project
Aug 26 2021
Aug 26 2021
simonwallis2 committed rGc4dc81eeabdb: [AArch64] provide strictfp attributes in test file (authored by simonwallis2).
[AArch64] provide strictfp attributes in test file
Aug 26 2021, 8:57 AM · Restricted Project
Aug 23 2021
Aug 23 2021
simonwallis2 added a comment to D107567: [AArch64] provide strictfp attributes in test file.
Ping?
Aug 23 2021, 7:52 AM · Restricted Project
simonwallis2 added a comment to D107259: [Arm] Add assert in T2 Imm7s code emitter.
Ping?
Aug 23 2021, 7:52 AM · Restricted Project
Aug 5 2021
Aug 5 2021
simonwallis2 requested review of D107567: [AArch64] provide strictfp attributes in test file.
Aug 5 2021, 6:36 AM · Restricted Project
Aug 4 2021
Aug 4 2021
simonwallis2 committed rG926975267175: [AArch64] Fix assert AArch64TargetLowering::ReplaceNodeResults (authored by simonwallis2).
[AArch64] Fix assert AArch64TargetLowering::ReplaceNodeResults
Aug 4 2021, 8:19 AM · Restricted Project
simonwallis2 updated the diff for D107452: [AArch64] Fix assert AArch64TargetLowering::ReplaceNodeResults.
I have moved some CHECK lines around in the test case, as suggested by reviewer.
Aug 4 2021, 8:08 AM · Restricted Project
simonwallis2 updated the diff for D107452: [AArch64] Fix assert AArch64TargetLowering::ReplaceNodeResults.
Updated test case, actioning most of the review comments.
Aug 4 2021, 7:31 AM · Restricted Project
simonwallis2 added inline comments to D107452: [AArch64] Fix assert AArch64TargetLowering::ReplaceNodeResults.
Aug 4 2021, 6:41 AM · Restricted Project
simonwallis2 requested review of D107452: [AArch64] Fix assert AArch64TargetLowering::ReplaceNodeResults.
Aug 4 2021, 5:46 AM · Restricted Project
Aug 2 2021
Aug 2 2021
Aug 2 2021, 2:40 AM · Restricted Project
simonwallis2 requested review of D107259: [Arm] Add assert in T2 Imm7s code emitter.
Aug 2 2021, 2:39 AM · Restricted Project
Mar 11 2021
Mar 11 2021
simonwallis2 committed rGb68bae6a94fb: [AArch64] Fix -Wunused-but-set-variable in GCC non-debug build (authored by simonwallis2).
[AArch64] Fix -Wunused-but-set-variable in GCC non-debug build
Mar 11 2021, 9:55 AM · Restricted Project
simonwallis2 requested review of D98431: [AArch64] Fix -Wunused-but-set-variable in GCC non-debug build.
Mar 11 2021, 8:43 AM · Restricted Project
Sep 14 2020
Sep 14 2020
simonwallis2 committed rG4946802c5f40: [ARM] Fix so immediates and pc relative checks (authored by simonwallis2).
[ARM] Fix so immediates and pc relative checks
Sep 14 2020, 12:57 AM · Restricted Project
Sep 10 2020
Sep 10 2020
simonwallis2 added a comment to D86949: [ARM] Fix so immediates and pc relative checks.
Ping.
Sep 10 2020, 11:27 PM · Restricted Project
Sep 8 2020
Sep 8 2020
simonwallis2 committed rG8ee1419ab688: [AARCH64][RegisterCoalescer] clang miscompiles zero-extension to long long (authored by simonwallis2).
[AARCH64][RegisterCoalescer] clang miscompiles zero-extension to long long
simonwallis2 closed D85956: [AARCH64][RegisterCoalescer] clang miscompiles zero-extension to long long.
Sep 8 2020, 12:10 AM · Restricted Project
Sep 7 2020
Sep 7 2020
simonwallis2 committed rG79ea83e104e3: [SelectionDAG] memcpy expansion of const volatile struct ignores const zero (authored by simonwallis2).
[SelectionDAG] memcpy expansion of const volatile struct ignores const zero
simonwallis2 closed D87134: [SelectionDAG] memcpy expansion of const volatile struct ignores const zero.
Sep 7 2020, 5:26 AM · Restricted Project
Sep 4 2020
Sep 4 2020
simonwallis2 requested review of D87134: [SelectionDAG] memcpy expansion of const volatile struct ignores const zero.
Sep 4 2020, 3:38 AM · Restricted Project
simonwallis2 updated the diff for D86949: [ARM] Fix so immediates and pc relative checks.
Reworded a comment. NFC.
Sep 4 2020, 1:15 AM · Restricted Project
simonwallis2 updated the diff for D85956: [AARCH64][RegisterCoalescer] clang miscompiles zero-extension to long long.
Added comments to implementation of AArch64RegisterInfo::shouldCoalesce()
Sep 4 2020, 12:38 AM · Restricted Project
Sep 3 2020
Sep 3 2020
simonwallis2 added inline comments to D86949: [ARM] Fix so immediates and pc relative checks.
Sep 3 2020, 8:11 AM · Restricted Project
simonwallis2 added inline comments to D85956: [AARCH64][RegisterCoalescer] clang miscompiles zero-extension to long long.
Sep 3 2020, 6:40 AM · Restricted Project
Sep 2 2020
Sep 2 2020
simonwallis2 added inline comments to D86949: [ARM] Fix so immediates and pc relative checks.
Sep 2 2020, 2:13 AM · Restricted Project
simonwallis2 updated the diff for D86949: [ARM] Fix so immediates and pc relative checks.
After review feedback: made some formatting changes in line with standard code style in LLVM.
Sep 2 2020, 2:11 AM · Restricted Project
Sep 1 2020
Sep 1 2020
simonwallis2 requested review of D86949: [ARM] Fix so immediates and pc relative checks.
Sep 1 2020, 8:11 AM · Restricted Project
Abandoning this patch.
I overlooked that NegOk is fine for ADR, encoding A2.
I failed to look beyond encoding A1.
Sep 1 2020, 6:14 AM · Restricted Project
simonwallis2 requested review of D86924: [ARM] Fix so immediates and pc relative checks.
Sep 1 2020, 3:17 AM · Restricted Project
simonwallis2 added inline comments to D84923: [ARM] Fix so immediates and pc relative checks.
Sep 1 2020, 2:51 AM · Restricted Project
Aug 28 2020
Aug 28 2020
simonwallis2 added inline comments to D85956: [AARCH64][RegisterCoalescer] clang miscompiles zero-extension to long long.
Aug 28 2020, 3:12 AM · Restricted Project
simonwallis2 updated the diff for D85956: [AARCH64][RegisterCoalescer] clang miscompiles zero-extension to long long.
Thanks for the feedback arsenm.
I've made all of the changes you suggested,
with 1 exception:
I have left in the IR for the declaration of @c.
Aug 28 2020, 3:12 AM · Restricted Project
Aug 26 2020
Aug 26 2020
simonwallis2 added inline comments to D84923: [ARM] Fix so immediates and pc relative checks.
Aug 26 2020, 5:17 AM · Restricted Project
simonwallis2 updated the diff for D84923: [ARM] Fix so immediates and pc relative checks.
getPCOffset: added handling of LEApcrelJT
Aug 26 2020, 2:30 AM · Restricted Project
simonwallis2 added inline comments to D84923: [ARM] Fix so immediates and pc relative checks.
Aug 26 2020, 2:29 AM · Restricted Project
Aug 25 2020
Aug 25 2020
simonwallis2 updated the diff for D84923: [ARM] Fix so immediates and pc relative checks.
Reinstated the change to pc offset.
This is necessary for ARM-state SO immediates.
Aug 25 2020, 1:33 AM · Restricted Project
Aug 20 2020
Aug 20 2020
simonwallis2 added reviewers for D85956: [AARCH64][RegisterCoalescer] clang miscompiles zero-extension to long long: arsenm, eugenis.
Aug 20 2020, 6:56 AM · Restricted Project
simonwallis2 updated the diff for D84923: [ARM] Fix so immediates and pc relative checks.
After review feedback, I removed the change to pc offset estimates from this patch.
This patch is now just about fixing the implementation of SO immediates.
Aug 20 2020, 6:43 AM · Restricted Project
Aug 18 2020
Aug 18 2020
simonwallis2 added reviewers for D85956: [AARCH64][RegisterCoalescer] clang miscompiles zero-extension to long long: MatzeB, chandlerc.
Aug 18 2020, 2:30 AM · Restricted Project
simonwallis2 updated the diff for D84923: [ARM] Fix so immediates and pc relative checks.
Fix order of arguments in 1 call to isCPEntryInRange()
Aug 18 2020, 2:01 AM · Restricted Project
Aug 18 2020, 1:57 AM · Restricted Project
Aug 17 2020
Aug 17 2020
simonwallis2 added inline comments to D84923: [ARM] Fix so immediates and pc relative checks.
Aug 17 2020, 11:54 PM · Restricted Project
Aug 13 2020
Aug 13 2020
simonwallis2 requested review of D85956: [AARCH64][RegisterCoalescer] clang miscompiles zero-extension to long long.
Aug 13 2020, 11:18 PM · Restricted Project
Jul 30 2020
Jul 30 2020
LGTM.
Jul 30 2020, 6:36 AM · Restricted Project
Jul 29 2020
Jul 29 2020
simonwallis2 committed rG6a05c6bfc8d3: [MachineCopyPropagation] BackwardPropagatableCopy: add check for… (authored by simonwallis2).
[MachineCopyPropagation] BackwardPropagatableCopy: add check for…
simonwallis2 closed D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
Jul 29 2020, 8:21 AM · Restricted Project
simonwallis2 added inline comments to D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
Jul 29 2020, 8:01 AM · Restricted Project
simonwallis2 updated the diff for D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
MIR test further reduced and cleaned up after latest feedback.
Jul 29 2020, 8:00 AM · Restricted Project
simonwallis2 updated the diff for D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
• Could you make the MIR test smaller to include minimal instructions trigger the error, so that reviewers can review it easier?
Test was 130 lines. Now 25 lines.
Jul 29 2020, 6:49 AM · Restricted Project
Jul 28 2020
Jul 28 2020
simonwallis2 added a comment to D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
Please review the recent changes made since the last review comments.
Jul 28 2020, 2:43 AM · Restricted Project
Jul 22 2020
Jul 22 2020
simonwallis2 committed rG94e4e37d5564: [Thumb] set code alignment for 16-bit load from constant pool (authored by simonwallis2).
[Thumb] set code alignment for 16-bit load from constant pool
Jul 22 2020, 2:13 AM · Restricted Project
simonwallis2 updated the diff for D84169: [Thumb] set code alignment for 16-bit load from constant pool.
Added MIR test, as suggested.
Jul 22 2020, 1:18 AM · Restricted Project
Jul 21 2020
Jul 21 2020
simonwallis2 updated the diff for D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
MIR test added, after useful feedback.
Jul 21 2020, 8:53 AM · Restricted Project
simonwallis2 added a comment to D84169: [Thumb] set code alignment for 16-bit load from constant pool.
Note that this bug is not restricted to loading 16-bit floating point literals using VLDR.16.
The same fault is displayed loading 16-bit short literals using LDRH.
Jul 21 2020, 2:23 AM · Restricted Project
simonwallis2 added a comment to D84169: [Thumb] set code alignment for 16-bit load from constant pool.
The significant phrase is the Align(PC, 4) part.
The calculated value of the offset depends on the alignment of the VLDR.16 instruction.
That is why the code section needs to be 4-byte aligned.
If the code section is 2-byte aligned and the linker places the section at a non-4-byte aligned address, the offset will point to a different address.
Jul 21 2020, 1:47 AM · Restricted Project
Jul 20 2020
Jul 20 2020
Herald added a project to D84169: [Thumb] set code alignment for 16-bit load from constant pool: Restricted Project.
Jul 20 2020, 6:38 AM · Restricted Project
Jul 17 2020
Jul 17 2020
simonwallis2 committed rG3e0ccf9a9075: [ARM] halfword store hits llvm_unreachable with big-endian (authored by simonwallis2).
[ARM] halfword store hits llvm_unreachable with big-endian
Jul 17 2020, 12:58 AM · Restricted Project
Jul 16 2020
Jul 16 2020
simonwallis2 updated the summary of D83947: [ARM] halfword store hits llvm_unreachable with big-endian.
Jul 16 2020, 11:55 PM · Restricted Project
simonwallis2 updated the summary of D83947: [ARM] halfword store hits llvm_unreachable with big-endian.
Jul 16 2020, 11:50 PM · Restricted Project
simonwallis2 updated the summary of D83947: [ARM] halfword store hits llvm_unreachable with big-endian.
Jul 16 2020, 11:28 PM · Restricted Project
Herald added a project to D83947: [ARM] halfword store hits llvm_unreachable with big-endian: Restricted Project.
Jul 16 2020, 6:24 AM · Restricted Project
Jul 9 2020
Jul 9 2020
simonwallis2 added a comment to D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
Yes, I used llc -stop-before=machine-cp mcp-dest-regs-no-dup.ll
to create the MIR test mcp-dest-regs-no-dup.mir
Jul 9 2020, 3:10 AM · Restricted Project
Jul 8 2020
Jul 8 2020
simonwallis2 added a comment to D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
Please review the recent changes made since the last review comments.
Jul 8 2020, 7:25 AM · Restricted Project
Jun 30 2020
Jun 30 2020
simonwallis2 updated the diff for D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
If the definition is earlyclobber, will it ever reach hasOverlappingMultipleDef?
Jun 30 2020, 4:18 AM · Restricted Project
Jun 26 2020
Jun 26 2020
simonwallis2 updated the diff for D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
Satisfy clang-format. NFC.
Jun 26 2020, 5:24 AM · Restricted Project
simonwallis2 created D82638: [MachineCopyPropagation] BackwardPropagatableCopy: add check for hasOverlappingMultipleDef.
Jun 26 2020, 3:45 AM · Restricted Project
Jun 9 2020
Jun 9 2020
simonwallis2 committed rG4dba59689d00: [ARM] prologue instructions emitted for naked function with >64 byte argument (authored by simonwallis2).
[ARM] prologue instructions emitted for naked function with >64 byte argument
simonwallis2 closed D80715: [ARM] prologue instructions emitted for naked function with >64 byte argument.
Jun 9 2020, 3:48 AM · Restricted Project
simonwallis2 committed rG0645c4d34f1c: [AVR][test] Remove test for naked function containing a return. (authored by simonwallis2).
[AVR][test] Remove test for naked function containing a return.
Jun 9 2020, 1:36 AM · Restricted Project
Jun 8 2020
Jun 8 2020
simonwallis2 committed rG7432fb2c7846: [ARM][XO] Execute-only miscompiles double literals for big-endian (authored by simonwallis2).
[ARM][XO] Execute-only miscompiles double literals for big-endian
Jun 8 2020, 12:30 AM · Restricted Project
Jun 5 2020
Jun 5 2020
Jun 5 2020, 6:33 AM · Restricted Project
Jun 3 2020
Jun 3 2020
Jun 3 2020, 8:12 AM · Restricted Project
May 28 2020
May 28 2020
simonwallis2 created D80715: [ARM] prologue instructions emitted for naked function with >64 byte argument.
May 28 2020, 5:57 AM · Restricted Project
May 13 2020
May 13 2020
simonwallis2 committed rG410644fbf767: Clang crash targeting ARM or Thumb when assembling a prel31 relocation variant (authored by simonwallis2).
Clang crash targeting ARM or Thumb when assembling a prel31 relocation variant
simonwallis2 closed D79782: Clang crash targeting ARM or Thumb when assembling a prel31 relocation variant.
May 13 2020, 5:54 AM · Restricted Project
May 12 2020
May 12 2020
simonwallis2 created D79782: Clang crash targeting ARM or Thumb when assembling a prel31 relocation variant.
May 12 2020, 6:57 AM · Restricted Project