This is an archive of the discontinued LLVM Phabricator instance.

[Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.
ClosedPublic

Authored by gAlfonso-bit on Aug 4 2021, 9:30 AM.

Details

Reviewers
RKSimon
rsmith
riccibruno
Group Reviewers
Restricted Project
Restricted Project
Commits
rGb0bf0b2e79e8: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

Diff Detail

Event Timeline

gAlfonso-bit requested review of this revision.Aug 4 2021, 9:30 AM
gAlfonso-bit created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2021, 9:30 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
gAlfonso-bit added a reviewer: Restricted Project.Aug 4 2021, 9:31 AM
gAlfonso-bit retitled this revision from [LLVM][AST][NFC] Resolve Fixme: Make CXXRecordDecl *Record const. to [Clang][AST][NFC] Resolve Fixme: Make CXXRecordDecl *Record const..Aug 4 2021, 9:34 AM
gAlfonso-bit added a reviewer: Restricted Project.
gAlfonso-bit retitled this revision from [Clang][AST][NFC] Resolve Fixme: Make CXXRecordDecl *Record const. to [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const..Aug 4 2021, 10:25 AM
gAlfonso-bit updated this revision to Diff 364584.EditedAug 5 2021, 12:45 PM

Added context to patch

RKSimon accepted this revision.Aug 17 2021, 9:01 AM

LGTM

This revision is now accepted and ready to land.Aug 17 2021, 9:01 AM

gentle ping

Sorry I forgot about this - I'll deal with this but you really need to request commit access

How do I request it?