This is an archive of the discontinued LLVM Phabricator instance.

[llvm-ar] Add some test-cases for empty archives
ClosedPublic

Authored by bd1976llvm on Aug 4 2021, 8:39 AM.

Details

Summary

We had coverage of empty archive in our downstream testsuite.

This adds those cases upstream.

Diff Detail

Event Timeline

bd1976llvm created this revision.Aug 4 2021, 8:39 AM
bd1976llvm requested review of this revision.Aug 4 2021, 8:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2021, 8:39 AM
MaskRay added inline comments.Aug 4 2021, 10:33 AM
llvm/test/tools/llvm-ar/display-empty.test
13

Delete | tee %t1.log which is only for debugging

14

With tv, t coverage may be redundant.

llvm/test/tools/llvm-ar/print.test
93

Delete | tee %t1.log which is only for debugging

bd1976llvm updated this revision to Diff 364379.Aug 5 2021, 1:34 AM

Arrg sorry! Uploaded an earlier incomplete revision by mistake.

  • I removed the extract from empty thin archive test as you can't extract from thin archives.
  • I addressed your review comments.

Thanks.

bd1976llvm marked 3 inline comments as done.Aug 5 2021, 1:35 AM
MaskRay accepted this revision.Aug 5 2021, 8:50 AM

LGTM.

This revision is now accepted and ready to land.Aug 5 2021, 8:50 AM