[lld] Remove unused LLD_REPOSITORY

[MaskRay]

Summary

Remnant after D72803.

Distributions who want to customize the string can customize
LLD_VERSION_STRING instead.

[mstorsjo]

LGTM

[thakis]

Thanks!

[GMNGeoffrey]

These variables still appear to be defined by https://github.com/llvm/llvm-project/blob/9c19b36f1c/lld/Common/CMakeLists.txt#L10-L11. Should they be removed there as well?

set(version_inc "${CMAKE_CURRENT_BINARY_DIR}/VCSVersion.inc")
set(generate_vcs_version_script "${LLVM_CMAKE_PATH}/GenerateVersionFromVCS.cmake")

[MaskRay]

In D107416#2926638, @GMNGeoffrey wrote:

These variables still appear to be defined by https://github.com/llvm/llvm-project/blob/9c19b36f1c/lld/Common/CMakeLists.txt#L10-L11. Should they be removed there as well?

set(version_inc "${CMAKE_CURRENT_BINARY_DIR}/VCSVersion.inc")
set(generate_vcs_version_script "${LLVM_CMAKE_PATH}/GenerateVersionFromVCS.cmake")

Looks like I probably should bring back the code.

The code ensures that we can get this ld.lld --version output when -DLLVM_APPEND_VC_REV=ON:

LLD 14.0.0 ([e-mail]:llvm/llvm-project.git a1944386156dbbfae15dfc606a3728e08ac92cfe) (compatible with GNU linkers)

lld/Common/Version.cpp

 //
 //===----------------------------------------------------------------------===//
 
 #include "lld/Common/Version.h"
 
 #include "VCSVersion.inc"
 
 // Returns a version string, e.g.:
-// lld 9.0.0 (https://github.com/llvm/llvm-project.git 9efdd7ac5e914d3c9fa1ef)
+// LLD 14.0.0 (https://github.com/llvm/llvm-project.git
+// 2d9759c7902c5cbc9a7e3ab623321d5578d51687)
 std::string lld::getLLDVersion() {
 #ifdef LLD_VENDOR
 #define LLD_VENDOR_DISPLAY LLD_VENDOR " "
 #else
 #define LLD_VENDOR_DISPLAY
 #endif
-#if defined(LLD_REPOSITORY) && defined(LLD_REVISION)
-  return LLD_VENDOR_DISPLAY "LLD " LLD_VERSION_STRING " (" LLD_REPOSITORY
-                            " " LLD_REVISION ")";
-#else
   return LLD_VENDOR_DISPLAY "LLD " LLD_VERSION_STRING;
-#endif
 #undef LLD_VENDOR_DISPLAY
 }