This is an archive of the discontinued LLVM Phabricator instance.

Differential D107325

[clang-tidy] Fix command line is too long issue which breaks test on Windows
ClosedPublic

Authored by dougpuob on Aug 2 2021, 11:26 PM.

Details

Reviewers
thakis
Commits
rG559d142331c2: [clang-tidy] Fix command line is too long issue which breaks test on Windows
Summary

This patch tries to fix command line too long problem on Windows for https://reviews.llvm.org/D86671.

The command line is too long with check_clang_tidy.py program on Windows, because the configuration is long for regression test. Fix this issue by creating a temporary response file then pass it to target program. (error log: http://45.33.8.238/win/43180/step_8.txt)

Diff Detail

Event Timeline

dougpuob created this revision.Aug 2 2021, 11:26 PM
Herald added a subscriber: xazax.hun. · View Herald TranscriptAug 2 2021, 11:26 PM
dougpuob requested review of this revision.Aug 2 2021, 11:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2021, 11:26 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B117565: Diff 363634.Aug 2 2021, 11:58 PM
dougpuob mentioned this in D86671: [clang-tidy] Add new case type to check variables with Hungarian notation.Aug 3 2021, 12:07 AM
dougpuob edited the summary of this revision. (Show Details)Aug 3 2021, 12:11 AM
dougpuob added a reviewer: thakis.
thakis added a comment.Aug 3 2021, 3:51 AM

Thanks!

Since the config file contents are fixed as far as I can tell, maybe we could instead just add a file with the right contents to clang-tools-extra/test/clang-tidy/checkers/Inputs and refer to that? (Use %S/Inputs/myfile.txt) (Alternatively you could use the split-file utility, but putting the file in Inputs is probably easier if you're new, and it's not any worse :) )

dougpuob updated this revision to Diff 363698.Aug 3 2021, 4:45 AM
  • Moved config content of regression test to clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-identifier-naming/hungarian-notation*/.clang-tidy, then refer to those files in tests.
Herald added a subscriber: aheejin. · View Herald TranscriptAug 3 2021, 4:45 AM
dougpuob added a comment.Aug 3 2021, 4:49 AM
In D107325#2921844, @thakis wrote:

Thanks!

Since the config file contents are fixed as far as I can tell, maybe we could instead just add a file with the right contents to clang-tools-extra/test/clang-tidy/checkers/Inputs and refer to that? (Use %S/Inputs/myfile.txt) (Alternatively you could use the split-file utility, but putting the file in Inputs is probably easier if you're new, and it's not any worse :) )

Hi @thakis:
It's a really good idea, thank you for the suggestion. I just upload the latest diff.

thakis accepted this revision.Aug 3 2021, 4:56 AM

Thanks!

clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-identifier-naming/hungarian-notation1/.clang-tidy
3

can we drop all the spaces here? :)

This revision is now accepted and ready to land.Aug 3 2021, 4:56 AM
whisperity added a subscriber: whisperity.Aug 3 2021, 5:02 AM

In general, would it be possible to specify the configuration file as a custom path, and not use the hidden filename .clang-tidy in an otherwise empty directory? I think there's a --config flag on Tidy's interface for giving any file from any path for this. So it could be config1.yaml or something like that instead.

clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-identifier-naming/hungarian-notation1/.clang-tidy
1

I do not think this file should have the execute bit set...

3

And maybe even the object brackets.

Harbormaster completed remote builds in B117608: Diff 363698.Aug 3 2021, 5:17 AM
dougpuob marked 3 inline comments as done.Aug 3 2021, 6:11 AM
dougpuob added inline comments.
clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-identifier-naming/hungarian-notation1/.clang-tidy
1

I will change it to 664.

3

Sure.

3

OK

dougpuob updated this revision to Diff 363717.Aug 3 2021, 6:12 AM
dougpuob marked 3 inline comments as done.
  • Improved code review suggestions.
Harbormaster completed remote builds in B117619: Diff 363717.Aug 3 2021, 6:52 AM
dougpuob added a comment.Aug 3 2021, 7:59 AM

Hi @thakis:
I can't access the repo, could you please help me to land?

Closed by commit rG559d142331c2: [clang-tidy] Fix command line is too long issue which breaks test on Windows (authored by dougpuob, committed by thakis). · Explain WhyAug 3 2021, 1:13 PM
This revision was automatically updated to reflect the committed changes.
thakis added a commit: rG559d142331c2: [clang-tidy] Fix command line is too long issue which breaks test on Windows.
thakis added a comment.Aug 3 2021, 1:40 PM

The bot is happy again, thanks.

dougpuob added a comment.Aug 3 2021, 8:14 PM
In D107325#2923518, @thakis wrote:

The bot is happy again, thanks.

Nice, thank you for your help :)

Revision Contents

PathSize
clang-tools-extra/
clang-tidy/
readability/
2 lines
test/
clang-tidy/
checkers/
Inputs/
readability-identifier-naming/
hungarian-notation1/
58 lines
hungarian-notation2/
137 lines
140 lines
61 lines

Diff 363698

clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp

Show First 20 Lines • Show All 485 Lines • ▼ Show 20 Lines for (const auto &Type : HungarainNotationUserDefinedTypes) {
if (!Val.empty()) if (!Val.empty())
HNOption.UserDefinedType[Type] = std::move(Val); HNOption.UserDefinedType[Type] = std::move(Val);
} }
} }
std::string IdentifierNamingCheck::HungarianNotation::getPrefix( std::string IdentifierNamingCheck::HungarianNotation::getPrefix(
const Decl *D, const Decl *D,
const IdentifierNamingCheck::HungarianNotationOption &HNOption) const { const IdentifierNamingCheck::HungarianNotationOption &HNOption) const {
if (!D)
return {};
const auto *ND = dyn_cast<NamedDecl>(D); const auto *ND = dyn_cast<NamedDecl>(D);
if (!ND) if (!ND)
return {}; return {};
std::string Prefix; std::string Prefix;
if (const auto *ECD = dyn_cast<EnumConstantDecl>(ND)) { if (const auto *ECD = dyn_cast<EnumConstantDecl>(ND)) {
Prefix = getEnumPrefix(ECD); Prefix = getEnumPrefix(ECD);
} else if (const auto *CRD = dyn_cast<CXXRecordDecl>(ND)) { } else if (const auto *CRD = dyn_cast<CXXRecordDecl>(ND)) {
▲ Show 20 Lines • Show All 943 Lines • Show Last 20 Lines

clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-identifier-naming/hungarian-notation1/.clang-tidy

  • This file was added.
PropertyOld ValueNew Value
File Modenull100755
Checks: readability-identifier-naming
whisperityUnsubmitted
Done
ReplyInline Actions

I do not think this file should have the execute bit set...

whisperity: I do not think this file should have the //execute// bit set...
dougpuobAuthorUnsubmitted
Done
ReplyInline Actions

I will change it to 664.

dougpuob: I will change it to 664.
CheckOptions:
- { key: readability-identifier-naming.AbstractClassCase , value: CamelCase }
thakisUnsubmitted
Done
ReplyInline Actions

can we drop all the spaces here? :)

thakis: can we drop all the spaces here? :)
dougpuobAuthorUnsubmitted
Done
ReplyInline Actions

Sure.

dougpuob: Sure.
whisperityUnsubmitted
Done
ReplyInline Actions
CheckOptions:
- - { key: readability-identifier-naming.AbstractClassCase , value: CamelCase }
+ - key: readability-identifier-naming.AbstractClassCase
+ value: CamelCase
- { key: readability-identifier-naming.ClassCase , value: CamelCase }

And maybe even the object brackets.

whisperity: And maybe even the object brackets.
dougpuobAuthorUnsubmitted
Done
ReplyInline Actions

OK

dougpuob: OK
- { key: readability-identifier-naming.ClassCase , value: CamelCase }
- { key: readability-identifier-naming.ClassConstantCase , value: CamelCase }
- { key: readability-identifier-naming.ClassMemberCase , value: CamelCase }
- { key: readability-identifier-naming.ConstantCase , value: CamelCase }
- { key: readability-identifier-naming.ConstantMemberCase , value: CamelCase }
- { key: readability-identifier-naming.ConstantParameterCase , value: CamelCase }
- { key: readability-identifier-naming.ConstantPointerParameterCase , value: CamelCase }
- { key: readability-identifier-naming.ConstexprVariableCase , value: CamelCase }
- { key: readability-identifier-naming.EnumConstantCase , value: CamelCase }
- { key: readability-identifier-naming.GlobalConstantCase , value: CamelCase }
- { key: readability-identifier-naming.GlobalConstantPointerCase , value: CamelCase }
- { key: readability-identifier-naming.GlobalPointerCase , value: CamelCase }
- { key: readability-identifier-naming.GlobalVariableCase , value: CamelCase }
- { key: readability-identifier-naming.LocalConstantCase , value: CamelCase }
- { key: readability-identifier-naming.LocalConstantPointerCase , value: CamelCase }
- { key: readability-identifier-naming.LocalPointerCase , value: CamelCase }
- { key: readability-identifier-naming.LocalVariableCase , value: CamelCase }
- { key: readability-identifier-naming.MemberCase , value: CamelCase }
- { key: readability-identifier-naming.ParameterCase , value: CamelCase }
- { key: readability-identifier-naming.PointerParameterCase , value: CamelCase }
- { key: readability-identifier-naming.PrivateMemberCase , value: CamelCase }
- { key: readability-identifier-naming.ProtectedMemberCase , value: CamelCase }
- { key: readability-identifier-naming.PublicMemberCase , value: CamelCase }
- { key: readability-identifier-naming.ScopedEnumConstantCase , value: CamelCase }
- { key: readability-identifier-naming.StaticConstantCase , value: CamelCase }
- { key: readability-identifier-naming.StaticVariableCase , value: CamelCase }
- { key: readability-identifier-naming.VariableCase , value: CamelCase }
- { key: readability-identifier-naming.AbstractClassHungarianPrefix , value: On }
- { key: readability-identifier-naming.ClassHungarianPrefix , value: On }
- { key: readability-identifier-naming.ClassConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.ClassMemberHungarianPrefix , value: On }
- { key: readability-identifier-naming.ConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.ConstantMemberHungarianPrefix , value: On }
- { key: readability-identifier-naming.ConstantParameterHungarianPrefix , value: On }
- { key: readability-identifier-naming.ConstantPointerParameterHungarianPrefix , value: On }
- { key: readability-identifier-naming.ConstexprVariableHungarianPrefix , value: On }
- { key: readability-identifier-naming.EnumConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.GlobalConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.GlobalConstantPointerHungarianPrefix , value: On }
- { key: readability-identifier-naming.GlobalPointerHungarianPrefix , value: On }
- { key: readability-identifier-naming.GlobalVariableHungarianPrefix , value: On }
- { key: readability-identifier-naming.LocalConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.LocalConstantPointerHungarianPrefix , value: On }
- { key: readability-identifier-naming.LocalPointerHungarianPrefix , value: On }
- { key: readability-identifier-naming.LocalVariableHungarianPrefix , value: On }
- { key: readability-identifier-naming.MemberHungarianPrefix , value: On }
- { key: readability-identifier-naming.ParameterHungarianPrefix , value: On }
- { key: readability-identifier-naming.PointerParameterHungarianPrefix , value: On }
- { key: readability-identifier-naming.PrivateMemberHungarianPrefix , value: On }
- { key: readability-identifier-naming.ProtectedMemberHungarianPrefix , value: On }
- { key: readability-identifier-naming.PublicMemberHungarianPrefix , value: On }
- { key: readability-identifier-naming.ScopedEnumConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.StaticConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.StaticVariableHungarianPrefix , value: On }
- { key: readability-identifier-naming.VariableHungarianPrefix , value: On }
No newline at end of file

clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-identifier-naming/hungarian-notation2/.clang-tidy

  • This file was added.
PropertyOld ValueNew Value
File Modenull100755
Checks: readability-identifier-naming
CheckOptions:
- { key: readability-identifier-naming.AbstractClassCase , value: CamelCase }
- { key: readability-identifier-naming.ClassCase , value: CamelCase }
- { key: readability-identifier-naming.ClassConstantCase , value: CamelCase }
- { key: readability-identifier-naming.ClassMemberCase , value: CamelCase }
- { key: readability-identifier-naming.ConstantCase , value: CamelCase }
- { key: readability-identifier-naming.ConstantMemberCase , value: CamelCase }
- { key: readability-identifier-naming.ConstantParameterCase , value: CamelCase }
- { key: readability-identifier-naming.ConstantPointerParameterCase , value: CamelCase }
- { key: readability-identifier-naming.ConstexprVariableCase , value: CamelCase }
- { key: readability-identifier-naming.EnumConstantCase , value: CamelCase }
- { key: readability-identifier-naming.GlobalConstantCase , value: CamelCase }
- { key: readability-identifier-naming.GlobalConstantPointerCase , value: CamelCase }
- { key: readability-identifier-naming.GlobalPointerCase , value: CamelCase }
- { key: readability-identifier-naming.GlobalVariableCase , value: CamelCase }
- { key: readability-identifier-naming.LocalConstantCase , value: CamelCase }
- { key: readability-identifier-naming.LocalConstantPointerCase , value: CamelCase }
- { key: readability-identifier-naming.LocalPointerCase , value: CamelCase }
- { key: readability-identifier-naming.LocalVariableCase , value: CamelCase }
- { key: readability-identifier-naming.MemberCase , value: CamelCase }
- { key: readability-identifier-naming.ParameterCase , value: CamelCase }
- { key: readability-identifier-naming.PointerParameterCase , value: CamelCase }
- { key: readability-identifier-naming.PrivateMemberCase , value: CamelCase }
- { key: readability-identifier-naming.ProtectedMemberCase , value: CamelCase }
- { key: readability-identifier-naming.PublicMemberCase , value: CamelCase }
- { key: readability-identifier-naming.ScopedEnumConstantCase , value: CamelCase }
- { key: readability-identifier-naming.StaticConstantCase , value: CamelCase }
- { key: readability-identifier-naming.StaticVariableCase , value: CamelCase }
- { key: readability-identifier-naming.VariableCase , value: CamelCase }
- { key: readability-identifier-naming.AbstractClassHungarianPrefix , value: On }
- { key: readability-identifier-naming.ClassHungarianPrefix , value: On }
- { key: readability-identifier-naming.ClassConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.ClassMemberHungarianPrefix , value: On }
- { key: readability-identifier-naming.ConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.ConstantMemberHungarianPrefix , value: On }
- { key: readability-identifier-naming.ConstantParameterHungarianPrefix , value: On }
- { key: readability-identifier-naming.ConstantPointerParameterHungarianPrefix , value: On }
- { key: readability-identifier-naming.ConstexprVariableHungarianPrefix , value: On }
- { key: readability-identifier-naming.EnumConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.GlobalConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.GlobalConstantPointerHungarianPrefix , value: On }
- { key: readability-identifier-naming.GlobalPointerHungarianPrefix , value: On }
- { key: readability-identifier-naming.GlobalVariableHungarianPrefix , value: On }
- { key: readability-identifier-naming.LocalConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.LocalConstantPointerHungarianPrefix , value: On }
- { key: readability-identifier-naming.LocalPointerHungarianPrefix , value: On }
- { key: readability-identifier-naming.LocalVariableHungarianPrefix , value: On }
- { key: readability-identifier-naming.MemberHungarianPrefix , value: On }
- { key: readability-identifier-naming.ParameterHungarianPrefix , value: On }
- { key: readability-identifier-naming.PointerParameterHungarianPrefix , value: On }
- { key: readability-identifier-naming.PrivateMemberHungarianPrefix , value: On }
- { key: readability-identifier-naming.ProtectedMemberHungarianPrefix , value: On }
- { key: readability-identifier-naming.PublicMemberHungarianPrefix , value: On }
- { key: readability-identifier-naming.ScopedEnumConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.StaticConstantHungarianPrefix , value: On }
- { key: readability-identifier-naming.StaticVariableHungarianPrefix , value: On }
- { key: readability-identifier-naming.VariableHungarianPrefix , value: On }
- { key: readability-identifier-naming.HungarianNotation.Options.TreatStructAsClass , value: false }
- { key: readability-identifier-naming.HungarianNotation.DerivedType.Array , value: ary }
- { key: readability-identifier-naming.HungarianNotation.DerivedType.Pointer , value: p }
- { key: readability-identifier-naming.HungarianNotation.DerivedType.FunctionPointer , value: fn }
- { key: readability-identifier-naming.HungarianNotation.CString.CharPrinter , value: sz }
- { key: readability-identifier-naming.HungarianNotation.CString.CharArray , value: sz }
- { key: readability-identifier-naming.HungarianNotation.CString.WideCharPrinter , value: wsz }
- { key: readability-identifier-naming.HungarianNotation.CString.WideCharArray , value: wsz }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.int8_t , value: i8 }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.int16_t , value: i16 }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.int32_t , value: i32 }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.int64_t , value: i64 }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.uint8_t , value: u8 }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.uint16_t , value: u16 }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.uint32_t , value: u32 }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.uint64_t , value: u64 }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.char8_t , value: c8 }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.char16_t , value: c16 }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.char32_t , value: c32 }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.float , value: f }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.double , value: d }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.char , value: c }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.bool , value: b }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType._Bool , value: b }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.int , value: i }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.size_t , value: n }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.wchar_t , value: wc }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.short-int , value: si }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.short , value: s }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-int , value: si }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-short , value: ss }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-short-int , value: ssi }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-long-long-int , value: slli }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-long-long , value: sll }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-long-int , value: sli }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-long , value: sl }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed , value: s }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-long-long-int , value: ulli }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-long-long , value: ull }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-long-int , value: uli }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-long , value: ul }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-short-int , value: usi }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-short , value: us }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-int , value: ui }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned , value: u }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.long-long-int , value: lli }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.long-double , value: ld }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.long-long , value: ll }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.long-int , value: li }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.long , value: l }
- { key: readability-identifier-naming.HungarianNotation.PrimitiveType.ptrdiff_t , value: p }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.BOOL , value: b }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.BOOLEAN , value: b }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.BYTE , value: by }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.CHAR , value: c }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.UCHAR , value: uc }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.SHORT , value: s }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.USHORT , value: us }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.WORD , value: w }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.DWORD , value: dw }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.DWORD32 , value: dw32 }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.DWORD64 , value: dw64 }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.LONG , value: l }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.ULONG , value: ul }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.ULONG32 , value: ul32 }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.ULONG64 , value: ul64 }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.ULONGLONG , value: ull }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.HANDLE , value: h }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT , value: i }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT8 , value: i8 }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT16 , value: i16 }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT32 , value: i32 }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT64 , value: i64 }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT , value: ui }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT8 , value: u8 }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT16 , value: u16 }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT32 , value: u32 }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT64 , value: u64 }
- { key: readability-identifier-naming.HungarianNotation.UserDefinedType.PVOID , value: p }

clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-hungarian-notation-cfgfile.cpp

// RUN: %check_clang_tidy %s readability-identifier-naming %t -- \ // RUN: clang-tidy %s --config-file=%S/Inputs/readability-identifier-naming/hungarian-notation1/.clang-tidy 2>&1 \
// RUN: -config='{ CheckOptions: [ \ // RUN: | FileCheck -check-prefixes=CHECK-MESSAGES %s
// RUN: { key: readability-identifier-naming.AbstractClassCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ClassCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ClassConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ClassMemberCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ConstantMemberCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ConstantParameterCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ConstantPointerParameterCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ConstexprVariableCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.EnumConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.GlobalConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.GlobalConstantPointerCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.GlobalPointerCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.GlobalVariableCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.LocalConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.LocalConstantPointerCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.LocalPointerCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.LocalVariableCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.MemberCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ParameterCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.PointerParameterCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.PrivateMemberCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ProtectedMemberCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.PublicMemberCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ScopedEnumConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.StaticConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.StaticVariableCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.VariableCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.AbstractClassHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ClassHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ClassConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ClassMemberHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ConstantMemberHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ConstantParameterHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ConstantPointerParameterHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ConstexprVariableHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.EnumConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.GlobalConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.GlobalConstantPointerHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.GlobalPointerHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.GlobalVariableHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.LocalConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.LocalConstantPointerHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.LocalPointerHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.LocalVariableHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.MemberHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ParameterHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.PointerParameterHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.PrivateMemberHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ProtectedMemberHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.PublicMemberHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ScopedEnumConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.StaticConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.StaticVariableHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.VariableHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.Options.TreatStructAsClass , value: false }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.DerivedType.Array , value: ary }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.DerivedType.Pointer , value: p }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.DerivedType.FunctionPointer , value: fn }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.CString.CharPrinter , value: sz }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.CString.CharArray , value: sz }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.CString.WideCharPrinter , value: wsz }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.CString.WideCharArray , value: wsz }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.int8_t , value: i8 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.int16_t , value: i16 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.int32_t , value: i32 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.int64_t , value: i64 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.uint8_t , value: u8 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.uint16_t , value: u16 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.uint32_t , value: u32 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.uint64_t , value: u64 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.char8_t , value: c8 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.char16_t , value: c16 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.char32_t , value: c32 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.float , value: f }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.double , value: d }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.char , value: c }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.bool , value: b }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType._Bool , value: b }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.int , value: i }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.size_t , value: n }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.wchar_t , value: wc }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.short-int , value: si }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.short , value: s }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-int , value: si }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-short , value: ss }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-short-int , value: ssi }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-long-long-int , value: slli }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-long-long , value: sll }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-long-int , value: sli }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-long , value: sl }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed , value: s }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-long-long-int , value: ulli }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-long-long , value: ull }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-long-int , value: uli }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-long , value: ul }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-short-int , value: usi }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-short , value: us }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-int , value: ui }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned , value: u }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.long-long-int , value: lli }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.long-double , value: ld }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.long-long , value: ll }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.long-int , value: li }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.long , value: l }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.PrimitiveType.ptrdiff_t , value: p }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.BOOL , value: b }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.BOOLEAN , value: b }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.BYTE , value: by }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.CHAR , value: c }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.UCHAR , value: uc }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.SHORT , value: s }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.USHORT , value: us }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.WORD , value: w }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.DWORD , value: dw }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.DWORD32 , value: dw32 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.DWORD64 , value: dw64 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.LONG , value: l }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.ULONG , value: ul }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.ULONG32 , value: ul32 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.ULONG64 , value: ul64 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.ULONGLONG , value: ull }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.HANDLE , value: h }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT , value: i }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT8 , value: i8 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT16 , value: i16 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT32 , value: i32 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT64 , value: i64 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT , value: ui }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT8 , value: u8 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT16 , value: u16 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT32 , value: u32 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT64 , value: u64 }, \
// RUN: { key: readability-identifier-naming.HungarianNotation.UserDefinedType.PVOID , value: p }, \
// RUN: ]}'
// clang-format off // clang-format off
typedef signed char int8_t; // NOLINT typedef signed char int8_t; // NOLINT
typedef short int16_t; // NOLINT typedef short int16_t; // NOLINT
typedef long int32_t; // NOLINT typedef long int32_t; // NOLINT
typedef long long int64_t; // NOLINT typedef long long int64_t; // NOLINT
typedef unsigned char uint8_t; // NOLINT typedef unsigned char uint8_t; // NOLINT
typedef unsigned short uint16_t; // NOLINT typedef unsigned short uint16_t; // NOLINT
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines

clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-hungarian-notation.cpp

// RUN: %check_clang_tidy %s readability-identifier-naming %t -- \ // RUN: clang-tidy %s --config-file=%S/Inputs/readability-identifier-naming/hungarian-notation2/.clang-tidy 2>&1 \
// RUN: -config='{ CheckOptions: [ \ // RUN: | FileCheck -check-prefixes=CHECK-MESSAGES %s
// RUN: { key: readability-identifier-naming.AbstractClassCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ClassCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ClassConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ClassMemberCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ConstantMemberCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ConstantParameterCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ConstantPointerParameterCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ConstexprVariableCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.EnumConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.GlobalConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.GlobalConstantPointerCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.GlobalPointerCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.GlobalVariableCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.LocalConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.LocalConstantPointerCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.LocalPointerCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.LocalVariableCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.MemberCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ParameterCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.PointerParameterCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.PrivateMemberCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ProtectedMemberCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.PublicMemberCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.ScopedEnumConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.StaticConstantCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.StaticVariableCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.VariableCase , value: CamelCase }, \
// RUN: { key: readability-identifier-naming.AbstractClassHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ClassHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ClassConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ClassMemberHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ConstantMemberHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ConstantParameterHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ConstantPointerParameterHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ConstexprVariableHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.EnumConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.GlobalConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.GlobalConstantPointerHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.GlobalPointerHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.GlobalVariableHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.LocalConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.LocalConstantPointerHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.LocalPointerHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.LocalVariableHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.MemberHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ParameterHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.PointerParameterHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.PrivateMemberHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ProtectedMemberHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.PublicMemberHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.ScopedEnumConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.StaticConstantHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.StaticVariableHungarianPrefix , value: On }, \
// RUN: { key: readability-identifier-naming.VariableHungarianPrefix , value: On }, \
// RUN: ]}'
// clang-format off // clang-format off
typedef signed char int8_t; // NOLINT typedef signed char int8_t; // NOLINT
typedef short int16_t; // NOLINT typedef short int16_t; // NOLINT
typedef long int32_t; // NOLINT typedef long int32_t; // NOLINT
typedef long long int64_t; // NOLINT typedef long long int64_t; // NOLINT
typedef unsigned char uint8_t; // NOLINT typedef unsigned char uint8_t; // NOLINT
typedef unsigned short uint16_t; // NOLINT typedef unsigned short uint16_t; // NOLINT
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines