Page MenuHomePhabricator

[libomptarget][amdcgn] Add build dependency for llvm-link
AbandonedPublic

Authored by JonChesterfield on Aug 2 2021, 5:33 PM.

Details

Summary

Direct copy of D107156 with llvm-link instead of opt

Diff Detail

Unit TestsFailed

TimeTest
670 msx64 debian > libomp.lock::omp_init_lock.c
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -I /var/lib/buildkite-agent/builds/llvm-project/openmp/runtime/test -I /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/src -L /var/lib/buildkite-agent/builds/llvm-project/build/lib -I /var/lib/buildkite-agent/builds/llvm-project/openmp/runtime/test/ompt /var/lib/buildkite-agent/builds/llvm-project/openmp/runtime/test/lock/omp_init_lock.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/test/lock/Output/omp_init_lock.c.tmp -lm -latomic && /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/test/lock/Output/omp_init_lock.c.tmp

Event Timeline

JonChesterfield created this revision.Aug 2 2021, 5:33 PM
JonChesterfield requested review of this revision.Aug 2 2021, 5:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2021, 5:33 PM

If D107156 is the correct way to specify a dependency on opt then this should specify a dependency on llvm-link which is used in the same pipeline as opt. Relying on the reviewer's better understanding of our build system in this copy/paste patch, thanks!

Actually, the "true" correct way should be https://reviews.llvm.org/D107156#2918009. :-)

In my latest re-build from main, I ran again into the issue with missing opt during runtime build.
I think, we need to declare the dependency to opt/llvm-link for the runtime/openmp target.

I've just been burned by this again but don't understand what the fix is. If not this, then what should we be doing here?

JonChesterfield abandoned this revision.Aug 19 2021, 1:51 PM