Direct copy of D107156 with llvm-link instead of opt
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
670 ms | x64 debian > libomp.lock::omp_init_lock.c |
Event Timeline
Comment Actions
If D107156 is the correct way to specify a dependency on opt then this should specify a dependency on llvm-link which is used in the same pipeline as opt. Relying on the reviewer's better understanding of our build system in this copy/paste patch, thanks!
Comment Actions
Actually, the "true" correct way should be https://reviews.llvm.org/D107156#2918009. :-)
Comment Actions
In my latest re-build from main, I ran again into the issue with missing opt during runtime build.
I think, we need to declare the dependency to opt/llvm-link for the runtime/openmp target.
Comment Actions
I've just been burned by this again but don't understand what the fix is. If not this, then what should we be doing here?