This is an archive of the discontinued LLVM Phabricator instance.

[OpenCL] allow generic address and non-generic defs for CL3.0
ClosedPublic

Authored by airlied on Aug 2 2021, 4:24 PM.

Details

Summary

This allows both sets of definitions to exist on CL 3.0

Diff Detail

Event Timeline

airlied created this revision.Aug 2 2021, 4:24 PM
airlied requested review of this revision.Aug 2 2021, 4:24 PM

@azabaznov is this what you meant? I haven't tested this yet as my clang dev box died, but I'll get to it as soon as I can.

Yeah, this looks good. Thanks! Please notify when this is ready to land.

Anastasia accepted this revision.Aug 3 2021, 5:24 AM

LGTM! Thanks

This revision is now accepted and ready to land.Aug 3 2021, 5:24 AM

@azabaznov no bad effects here in my initial basic testing with CL 3.0, I'll land this tomorrow or next day when I get a chance.

This revision was landed with ongoing or failed builds.Aug 4 2021, 2:33 PM
This revision was automatically updated to reflect the committed changes.