This is an archive of the discontinued LLVM Phabricator instance.

Differential D107260

[flang][nfc] Add a regression test for #50993
ClosedPublic

Authored by awarzynski on Aug 2 2021, 3:26 AM.

Details

Reviewers
sscalpone
DavidTruby
klausler
Commits
rGad2e830fe2f7: [flang][nfc] Add a regression test for #50993
Summary

https://bugs.llvm.org/show_bug.cgi?id=50993 was effectively fixed in
https://reviews.llvm.org/D106727. This patch adds a regression
test specifically for the use case reported in 50993.

Diff Detail

Event Timeline

awarzynski created this revision.Aug 2 2021, 3:26 AM
Herald added a reviewer: sscalpone. · View Herald TranscriptAug 2 2021, 3:26 AM
awarzynski requested review of this revision.Aug 2 2021, 3:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2021, 3:26 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
awarzynski added reviewers: DavidTruby, klausler.Aug 2 2021, 3:27 AM
awarzynski added a project: Restricted Project.
Herald added a subscriber: jdoerfert. · View Herald TranscriptAug 2 2021, 3:27 AM
Harbormaster completed remote builds in B117416: Diff 363425.Aug 2 2021, 4:05 AM
DavidTruby accepted this revision.Aug 2 2021, 6:00 AM

LGTM, thanks @klausler for the quick fix and @awarzynski for the test! Feel free to close the bug on bugzilla

This revision is now accepted and ready to land.Aug 2 2021, 6:00 AM
Closed by commit rGad2e830fe2f7: [flang][nfc] Add a regression test for #50993 (authored by awarzynski). · Explain WhyAug 2 2021, 11:23 AM
This revision was automatically updated to reflect the committed changes.
awarzynski added a commit: rGad2e830fe2f7: [flang][nfc] Add a regression test for #50993.

Revision Contents

PathSize
flang/
test/
Preprocessing/
15 lines

Diff 363531

flang/test/Preprocessing/parse-preprocessed.F

  • This file was added.
! Verify that the output from `-E` is valid fixed-form source. See
! https://bugs.llvm.org/show_bug.cgi?id=50993.
! RUN: %flang_fc1 -E %s 2>&1 | %flang_fc1 -fsyntax-only -ffixed-form 2>&1 | FileCheck %s --allow-empty
! CHECK-NOT: error
! CHECK-NOT: warning
! https://bugs.llvm.org/show_bug.cgi?id=51219
! CHECK-NOT: Character in fixed-form label field must be a digit
PROGRAM HELLO
write(*, *), "hello, world!"
c Some irrelevant comment that's only valid in fixed-form
END PROGRAM