[clang-repl] Fix building with win32 dylibs

[mstorsjo]

Summary

Use clang_target_link_libraries to avoid duplicate libraries when
the same symbol is provided both by a static library and a larger
dylib, fixing linking with win32 dylibs. This fixes errors like
these:

ld.lld: error: duplicate symbol: llvm::createStringError(std::__1::error_code, char const*)
>>> defined at libLLVMSupport.a(Error.cpp.obj)
>>> defined at libLLVM-14git.dll

This matches how other clang tools declare their dependencies.

[v.g.vassilev]

Thanks!

[v.g.vassilev]

Forgot to mention that we may need to backport this patch to the llvm13 branch.

[mstorsjo]

In D107231#2918824, @v.g.vassilev wrote:

Forgot to mention that we may need to backport this patch to the llvm13 branch.

That might be good yes, especially if you intend to enable it by default there too. (I only noticed this after it was enabled by default).

[v.g.vassilev]

In D107231#2918834, @mstorsjo wrote:

In D107231#2918824, @v.g.vassilev wrote:

Forgot to mention that we may need to backport this patch to the llvm13 branch.

That might be good yes, especially if you intend to enable it by default there too. (I only noticed this after it was enabled by default).

It should be enabled already for the llvm13 branch.

[mstorsjo]

In D107231#2918835, @v.g.vassilev wrote:

In D107231#2918834, @mstorsjo wrote:

In D107231#2918824, @v.g.vassilev wrote:

Forgot to mention that we may need to backport this patch to the llvm13 branch.

That might be good yes, especially if you intend to enable it by default there too. (I only noticed this after it was enabled by default).

It should be enabled already for the llvm13 branch.

Oh, I had missed that this was changed right before the branch (I did my last similar test build a couple days before the branch). Yes then it indeed needs to be backported. @tstellar ok to backport?

[tstellar]

@mstorsjo Yes, go ahead.

clang/tools/clang-repl/CMakeLists.txt

 set( LLVM_LINK_COMPONENTS
   ${LLVM_TARGETS_TO_BUILD}
   Core
   Option
   OrcJIT
   Support
   )
 
 add_clang_executable(clang-repl
   ClangRepl.cpp
   )
 
-target_link_libraries(clang-repl PUBLIC
+clang_target_link_libraries(clang-repl PUBLIC
   clangBasic
   clangInterpreter
   clangTooling
   LLVMLineEditor
   )