This is an archive of the discontinued LLVM Phabricator instance.

Differential D107113

[MLIR][python] Disable SONAME on extensions.
ClosedPublic

Authored by stellaraccident on Jul 29 2021, 3:24 PM.

Details

Reviewers
mikeurbach
Commits
rG1de7a17ff320: [MLIR][python] Disable SONAME on extensions.
Summary

Diff Detail

Event Timeline

stellaraccident created this revision.Jul 29 2021, 3:24 PM
Herald added subscribers: Chia-hungDuan, shabalin, dcaballe and 19 others. · View Herald TranscriptJul 29 2021, 3:24 PM
stellaraccident requested review of this revision.Jul 29 2021, 3:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2021, 3:24 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
stellaraccident added a reviewer: mikeurbach.Jul 29 2021, 3:24 PM
mikeurbach accepted this revision.Jul 29 2021, 3:35 PM
This revision is now accepted and ready to land.Jul 29 2021, 3:35 PM
Harbormaster completed remote builds in B117062: Diff 362906.Jul 29 2021, 4:03 PM
Closed by commit rG1de7a17ff320: [MLIR][python] Disable SONAME on extensions. (authored by stellaraccident). · Explain WhyJul 29 2021, 5:47 PM
This revision was automatically updated to reflect the committed changes.
stellaraccident added a commit: rG1de7a17ff320: [MLIR][python] Disable SONAME on extensions..

Revision Contents

PathSize
mlir/
cmake/
modules/
1 line

Diff 362936

mlir/cmake/modules/AddMLIRPython.cmake

Show First 20 Lines • Show All 479 Lines • ▼ Show 20 Linesfunction(add_mlir_python_extension libname extname)
# Configure the output to match python expectations. # Configure the output to match python expectations.
set_target_properties( set_target_properties(
${libname} PROPERTIES ${libname} PROPERTIES
LIBRARY_OUTPUT_DIRECTORY ${ARG_OUTPUT_DIRECTORY} LIBRARY_OUTPUT_DIRECTORY ${ARG_OUTPUT_DIRECTORY}
OUTPUT_NAME "${extname}" OUTPUT_NAME "${extname}"
PREFIX "${PYTHON_MODULE_PREFIX}" PREFIX "${PYTHON_MODULE_PREFIX}"
SUFFIX "${PYTHON_MODULE_SUFFIX}${PYTHON_MODULE_EXTENSION}" SUFFIX "${PYTHON_MODULE_SUFFIX}${PYTHON_MODULE_EXTENSION}"
NO_SONAME ON
) )
if(WIN32) if(WIN32)
# Need to also set the RUNTIME_OUTPUT_DIRECTORY on Windows in order to # Need to also set the RUNTIME_OUTPUT_DIRECTORY on Windows in order to
# control where the .dll gets written. # control where the .dll gets written.
set_target_properties( set_target_properties(
${libname} PROPERTIES ${libname} PROPERTIES
RUNTIME_OUTPUT_DIRECTORY ${ARG_OUTPUT_DIRECTORY} RUNTIME_OUTPUT_DIRECTORY ${ARG_OUTPUT_DIRECTORY}
Show All 38 Lines