Page MenuHomePhabricator
Differential D107106

[SLP]Do not consider deleted instruction as external users.
ClosedPublic
Actions

Authored by ABataev on Jul 29 2021, 2:31 PM.

Details

Reviewers
RKSimon
spatel
anton-afanasyev
dtemirbulatov
Commits
rGf4fb85481136: [SLP]Do not consider deleted instruction as external users.
Summary

If the instruction was previously deleted, it should not be treated as
an external user. This fixes cost estimation and removes dead
extractelement instructions.

Diff Detail

Event Timeline

ABataev created this revision.Jul 29 2021, 2:31 PM
Herald added a subscriber: hiraditya. · View Herald TranscriptJul 29 2021, 2:31 PM
ABataev requested review of this revision.Jul 29 2021, 2:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2021, 2:31 PM
Harbormaster completed remote builds in B117049: Diff 362886.Jul 29 2021, 3:45 PM
dtemirbulatov accepted this revision.Jul 29 2021, 5:26 PM

LGTM.

This revision is now accepted and ready to land.Jul 29 2021, 5:26 PM
This revision was landed with ongoing or failed builds.Jul 30 2021, 5:38 AM
Closed by commit rGf4fb85481136: [SLP]Do not consider deleted instruction as external users. (authored by ABataev). · Explain Why
This revision was automatically updated to reflect the committed changes.
ABataev added a commit: rGf4fb85481136: [SLP]Do not consider deleted instruction as external users..

Revision Contents
Changeset List

PathSize
llvm/
lib/
Transforms/
Vectorize/
7 lines
test/
Transforms/
SLPVectorizer/
AArch64/
58 lines
SystemZ/
19 lines
X86/
2 lines
4 lines
16 lines
6 lines
69 lines

Diff 363045

View Options

llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/AArch64/gather-root.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/SystemZ/pr34619.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/X86/PR39774.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/X86/addsub.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/X86/horizontal-minmax.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/X86/ordering-bug.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/X86/resched.ll

Loading...