This is an archive of the discontinued LLVM Phabricator instance.

Set TargetCPUName for AIX to default to pwr7.
ClosedPublic

Authored by jamieschmeiser on Jul 29 2021, 5:59 AM.

Details

Summary

Set the TargetCPUName for AIX to default to pwr7, removing the setting
of it based on the major/minor of the OS version, which previously
set it to pwr4 for AIX 7.1 and earlier. The old code would also set it to
pwr4 when the OS version was not specified and with the change, it will
default it to pwr7 in all cases.

Diff Detail

Event Timeline

jamieschmeiser requested review of this revision.Jul 29 2021, 5:59 AM
jamieschmeiser created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2021, 5:59 AM

LGTM with comment.

clang/test/Driver/aix-mcpu-default.c
9

I suggest this test be modified to check that the target cpu is power7 even when the version level is unspecified.

This revision is now accepted and ready to land.Jul 29 2021, 6:27 AM

Thanks @jamieschmeiser this change LGTM but I'll defer to @hubert.reinterpretcast for final approval.

Respond to review comment: expand testing.

This revision was landed with ongoing or failed builds.Jul 29 2021, 7:00 AM
This revision was automatically updated to reflect the committed changes.