[SPEC2017] Add timeit dependencies to validator and bench binaries.

[fhahn]

Summary

Both the benchmark and validator binaries require timeit on the host
system to measure the build times. They also need timeit-target, to
measure execution time on the system where the benchmarks execute.

This patch explicitly adds those dependencies, so they are guaranteed to
be built, even if individual benchmark binaries are built.

[Meinersbur]

Shouldn't the top-level CMakeLists.txt be responsible to build build-timeit before building anything? This looks like a recursive problem because TEST_SUITE_COLLECT_COMPILE_TIME sets

set(CMAKE_C_COMPILE_OBJECT "${CMAKE_BINARY_DIR}/tools/timeit --summary <OBJECT>.time ${CMAKE_C_COMPILE_OBJECT}")

but that command line is also used to compile timeit.c. How does this even work?

[Meinersbur]

If there are no easy answers to my questions, I'd just approve the patch. At worst we have redundant dependencies to timeit or build it even with though TEST_SUITE_COLLECT_COMPILE_TIME=OFF.

[fhahn]

In D107060#2914802, @Meinersbur wrote:

If there are no easy answers to my questions, I'd just approve the patch. At worst we have redundant dependencies to timeit or build it even with though TEST_SUITE_COLLECT_COMPILE_TIME=OFF.

I'm not entirely sure myself. I *think* at least for llvm_test_executable(${PROG} ${_sources}) it should not be needed, because the dependencies should be added elsewhere already. Let me try to reproduce the issue again before continuing.

[fhahn]

In D107060#2914840, @fhahn wrote:

In D107060#2914802, @Meinersbur wrote:

If there are no easy answers to my questions, I'd just approve the patch. At worst we have redundant dependencies to timeit or build it even with though TEST_SUITE_COLLECT_COMPILE_TIME=OFF.

I'm not entirely sure myself. I *think* at least for llvm_test_executable(${PROG} ${_sources}) it should not be needed, because the dependencies should be added elsewhere already. Let me try to reproduce the issue again before continuing.

I ran into the build failure again and I think it is just the validator binary that is missing the dependency. The committed version only adds build-timeit to the validator binary.

External/SPEC/SpecCPU2017.cmake

macro(speccpu2017_validate_image _imgfile _cmpfile _outfile)
 
   set(VALIDATOR imagevalidate_${BENCHMARK_NO}-target)
   if (NOT TARGET ${VALIDATOR})
     file(GLOB_RECURSE _validator_sources "${SRC_DIR}/image_validator/*.c")
 
     add_executable(${VALIDATOR} ${_validator_sources})
     target_link_libraries(${VALIDATOR} m)
     set_target_properties(${VALIDATOR} PROPERTIES COMPILE_FLAGS "-DSPEC")
+    add_dependencies(${VALIDATOR} build-timeit)
     add_dependencies(${VALIDATOR} build-timeit-target)
   endif ()
 
   if ((NOT DEFINED _carg_SUITE_TYPE) OR (${BENCHMARK_SUITE_TYPE} IN_LIST _carg_SUITE_TYPE))
     get_filename_component(_basename "${_imgfile}" NAME_WE)
     get_filename_component(_ext "${_imgfile}" EXT)
     llvm_test_verify(
       cd "${RUN_${_carg_RUN_TYPE}_DIR}" &&