This is an archive of the discontinued LLVM Phabricator instance.

Differential D107059

[SPEC2017] Add support for Darwin platforms.
ClosedPublic

Authored by fhahn on Jul 29 2021, 5:30 AM.

Details

Reviewers
naromero77
Meinersbur
cmatthews
paquette
Commits
rT56e28a7fe120: [SPEC2017] Add support for Darwin platforms.
Summary

This patch adds detection of Darwin platforms and the corresponding defines.

Diff Detail

Event Timeline

fhahn created this revision.Jul 29 2021, 5:30 AM
Herald added a subscriber: mgorny. · View Herald TranscriptJul 29 2021, 5:30 AM
Harbormaster completed remote builds in B116939: Diff 362727.Jul 29 2021, 5:30 AM
fhahn requested review of this revision.Jul 29 2021, 5:30 AM
fhahn updated this revision to Diff 362730.Jul 29 2021, 5:36 AM

Guard perlbench define by TARGET_OS == Darwin

Harbormaster completed remote builds in B116942: Diff 362730.Jul 29 2021, 5:36 AM
Meinersbur accepted this revision.Jul 29 2021, 11:55 AM

LGTM

This revision is now accepted and ready to land.Jul 29 2021, 11:55 AM
Closed by commit rT56e28a7fe120: [SPEC2017] Add support for Darwin platforms. (authored by fhahn). · Explain WhyJul 29 2021, 1:27 PM
This revision was automatically updated to reflect the committed changes.
fhahn added a commit: rT56e28a7fe120: [SPEC2017] Add support for Darwin platforms..

Revision Contents

PathSize
External/
SPEC/
CINT2017rate/
500.perlbench_r/
4 lines
2 lines

Diff 362730

External/SPEC/CINT2017rate/500.perlbench_r/CMakeLists.txt

# https://www.spec.org/cpu2017/Docs/benchmarks/500.perlbench_r.html # https://www.spec.org/cpu2017/Docs/benchmarks/500.perlbench_r.html
include(../../SpecCPU2017.cmake) include(../../SpecCPU2017.cmake)
if (NOT TEST_SUITE_SPEC2017_ROOT) if (NOT TEST_SUITE_SPEC2017_ROOT)
return () return ()
endif () endif ()
speccpu2017_benchmark(RATE) speccpu2017_benchmark(RATE)
if (TARGET_OS STREQUAL "Darwin")
add_definitions(-DSPEC_MACOSX_X64)
endif ()
add_definitions( add_definitions(
-DPERL_CORE -DPERL_CORE
-DDOUBLE_SLASHES_SPECIAL=0 -DDOUBLE_SLASHES_SPECIAL=0
-D_LARGE_FILES -D_LARGE_FILES
-D_LARGEFILE_SOURCE -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -D_FILE_OFFSET_BITS=64
) )
speccpu2017_add_include_dirs( speccpu2017_add_include_dirs(
▲ Show 20 Lines • Show All 151 Lines • Show Last 20 Lines

External/SPEC/SpecCPU2017.cmake

Show First 20 Lines • Show All 152 Lines • ▼ Show 20 Linesmacro (speccpu2017_benchmark)
list(APPEND SPEC_COMMON_DEFS "-D_FILE_OFFSET_BITS=64") list(APPEND SPEC_COMMON_DEFS "-D_FILE_OFFSET_BITS=64")
list(APPEND SPEC_COMMON_DEFS "-DSPEC_LINUX_I32") # perlbench list(APPEND SPEC_COMMON_DEFS "-DSPEC_LINUX_I32") # perlbench
endif () endif ()
elseif (ARCH STREQUAL "AArch64" AND TARGET_OS STREQUAL "Linux" AND CMAKE_SIZEOF_VOID_P EQUAL 8) elseif (ARCH STREQUAL "AArch64" AND TARGET_OS STREQUAL "Linux" AND CMAKE_SIZEOF_VOID_P EQUAL 8)
# Linux ARM # Linux ARM
list(APPEND SPEC_COMMON_DEFS "-DSPEC_LINUX_AARCH64") list(APPEND SPEC_COMMON_DEFS "-DSPEC_LINUX_AARCH64")
elseif (ARCH STREQUAL "x86" AND TARGET_OS STREQUAL "Windows") elseif (ARCH STREQUAL "x86" AND TARGET_OS STREQUAL "Windows")
# Windows x86/x64 # Windows x86/x64
elseif (TARGET_OS STREQUAL "Darwin")
add_definitions(-DSPEC_MACOSX)
else () else ()
message("ARCH: ${ARCH}") message("ARCH: ${ARCH}")
message("TARGET_OS: ${TARGET_OS}") message("TARGET_OS: ${TARGET_OS}")
message("CMAKE_SIZEOF_VOID_P: ${CMAKE_SIZEOF_VOID_P}") message("CMAKE_SIZEOF_VOID_P: ${CMAKE_SIZEOF_VOID_P}")
message(FATAL_ERROR message(FATAL_ERROR
"Don't know portability flags for SPEC CPU 2017 on this platform") "Don't know portability flags for SPEC CPU 2017 on this platform")
endif () endif ()
▲ Show 20 Lines • Show All 254 Lines • Show Last 20 Lines