This is an archive of the discontinued LLVM Phabricator instance.

Differential D106914

[libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT
ClosedPublic

Authored by jsji on Jul 27 2021, 1:12 PM.

Details

Reviewers
tstellar
MaskRay
hubert.reinterpretcast
Group Reviewers
Restricted Project
Commits
rGe07f9342be71: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT
Summary

There are some platform that might not have version script support,
don't try to use version script on those.

Diff Detail

Event Timeline

jsji created this revision.Jul 27 2021, 1:12 PM
Herald added a subscriber: mgorny. · View Herald TranscriptJul 27 2021, 1:12 PM
jsji requested review of this revision.Jul 27 2021, 1:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2021, 1:12 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
hubert.reinterpretcast accepted this revision.Jul 27 2021, 1:16 PM

LGTM; thanks!

This revision is now accepted and ready to land.Jul 27 2021, 1:16 PM
jsji mentioned this in D105527: libclang.so: Make SONAME independent from LLVM version.Jul 27 2021, 1:16 PM
MaskRay accepted this revision.Jul 27 2021, 1:17 PM
This revision was landed with ongoing or failed builds.Jul 27 2021, 1:19 PM
Closed by commit rGe07f9342be71: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT (authored by jsji). · Explain Why
This revision was automatically updated to reflect the committed changes.
jsji added a commit: rGe07f9342be71: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT.
tstellar added a comment.Jul 27 2021, 1:19 PM

LGTM. Thanks for fixing this.

Harbormaster completed remote builds in B116525: Diff 362155.Jul 27 2021, 3:27 PM

Revision Contents

PathSize
clang/
tools/
libclang/
2 lines

Diff 362160

clang/tools/libclang/CMakeLists.txt

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Linesif(MSVC)
# Avoid LNK4197 by not specifying libclang.exports here. # Avoid LNK4197 by not specifying libclang.exports here.
# Each functions is exported as "dllexport" in include/clang-c. # Each functions is exported as "dllexport" in include/clang-c.
# KB835326 # KB835326
set(LLVM_EXPORTED_SYMBOL_FILE) set(LLVM_EXPORTED_SYMBOL_FILE)
endif() endif()
if (UNIX AND NOT APPLE) if (UNIX AND NOT APPLE)
set(LLVM_EXPORTED_SYMBOL_FILE) set(LLVM_EXPORTED_SYMBOL_FILE)
set(USE_VERSION_SCRIPT TRUE) set(USE_VERSION_SCRIPT ${LLVM_HAVE_LINK_VERSION_SCRIPT})
endif() endif()
if (LLVM_EXPORTED_SYMBOL_FILE) if (LLVM_EXPORTED_SYMBOL_FILE)
add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE} add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE}
COMMAND "${Python3_EXECUTABLE}" COMMAND "${Python3_EXECUTABLE}"
ARGS ${CMAKE_CURRENT_SOURCE_DIR}/linker-script-to-export-list.py ARGS ${CMAKE_CURRENT_SOURCE_DIR}/linker-script-to-export-list.py
${LIBCLANG_VERSION_SCRIPT_FILE} ${LIBCLANG_VERSION_SCRIPT_FILE}
${LLVM_EXPORTED_SYMBOL_FILE} ${LLVM_EXPORTED_SYMBOL_FILE}
▲ Show 20 Lines • Show All 132 Lines • Show Last 20 Lines