This is an archive of the discontinued LLVM Phabricator instance.

Differential D106680

[WebAssembly][NFC] Simplify SIMD bitconvert pattern
ClosedPublic

Authored by tlively on Jul 23 2021, 9:29 AM.

Details

Reviewers
aheejin
Commits
rG39c0e4afce5d: [WebAssembly][NFC] Simplify SIMD bitconvert pattern

Diff Detail

Unit TestsFailed

TimeTest
2,500 msx64 debian > libarcher.barrier::barrier.c
2,660 msx64 debian > libarcher.critical::critical.c
2,680 msx64 debian > libarcher.critical::lock-nested.c
2,780 msx64 debian > libarcher.parallel::parallel-simple.c
2,770 msx64 debian > libarcher.parallel::parallel-simple2.c
View Full Test Results (20 Failed)

Event Timeline

tlively created this revision.Jul 23 2021, 9:29 AM
Herald added subscribers: wingo, ecnelises, sunfish and 4 others. · View Herald TranscriptJul 23 2021, 9:29 AM
tlively requested review of this revision.Jul 23 2021, 9:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2021, 9:29 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B115886: Diff 361259.Jul 23 2021, 10:46 AM
aheejin accepted this revision.Jul 23 2021, 2:32 PM

Nice!

This revision is now accepted and ready to land.Jul 23 2021, 2:32 PM
This revision was landed with ongoing or failed builds.Jul 23 2021, 2:43 PM
Closed by commit rG39c0e4afce5d: [WebAssembly][NFC] Simplify SIMD bitconvert pattern (authored by tlively). · Explain Why
This revision was automatically updated to reflect the committed changes.
tlively added a commit: rG39c0e4afce5d: [WebAssembly][NFC] Simplify SIMD bitconvert pattern.

Revision Contents

PathSize
llvm/
lib/
Target/
WebAssembly/
12 lines

Diff 361259

llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td

Show First 20 Lines • Show All 1,286 Lines • ▼ Show 20 Lines def : Pat<(node vec.vt:$val, (WebAssemblywrapper tglobaladdr:$off)),
Requires<[IsNotPIC, HasAddr64]>; Requires<[IsNotPIC, HasAddr64]>;
} }
defm : NarrowingStorePatGlobalAddrOffOnly<I16x8, store_v8i8_trunc_v8i16>; defm : NarrowingStorePatGlobalAddrOffOnly<I16x8, store_v8i8_trunc_v8i16>;
defm : NarrowingStorePatGlobalAddrOffOnly<I32x4, store_v4i16_trunc_v4i32>; defm : NarrowingStorePatGlobalAddrOffOnly<I32x4, store_v4i16_trunc_v4i32>;
// Bitcasts are nops // Bitcasts are nops
// Matching bitcast t1 to t1 causes strange errors, so avoid repeating types // Matching bitcast t1 to t1 causes strange errors, so avoid repeating types
foreach t1 = [v16i8, v8i16, v4i32, v2i64, v4f32, v2f64] in foreach t1 = AllVecs in
foreach t2 = !foldl( foreach t2 = AllVecs in
[]<ValueType>, [v16i8, v8i16, v4i32, v2i64, v4f32, v2f64], if !ne(t1, t2) then
acc, cur, !if(!eq(!cast<string>(t1), !cast<string>(cur)), def : Pat<(t1.vt (bitconvert (t2.vt V128:$v))), (t1.vt V128:$v)>;
acc, !listconcat(acc, [cur])
)
) in
def : Pat<(t1 (bitconvert (t2 V128:$v))), (t1 V128:$v)>;
// Extended pairwise addition // Extended pairwise addition
defm "" : SIMDConvert<I16x8, I8x16, int_wasm_extadd_pairwise_signed, defm "" : SIMDConvert<I16x8, I8x16, int_wasm_extadd_pairwise_signed,
"extadd_pairwise_i8x16_s", 0x7c>; "extadd_pairwise_i8x16_s", 0x7c>;
defm "" : SIMDConvert<I16x8, I8x16, int_wasm_extadd_pairwise_unsigned, defm "" : SIMDConvert<I16x8, I8x16, int_wasm_extadd_pairwise_unsigned,
"extadd_pairwise_i8x16_u", 0x7d>; "extadd_pairwise_i8x16_u", 0x7d>;
defm "" : SIMDConvert<I32x4, I16x8, int_wasm_extadd_pairwise_signed, defm "" : SIMDConvert<I32x4, I16x8, int_wasm_extadd_pairwise_signed,
"extadd_pairwise_i16x8_s", 0x7e>; "extadd_pairwise_i16x8_s", 0x7e>;
Show All 19 Lines