This is an archive of the discontinued LLVM Phabricator instance.

[CSSPGO] Fix a typo in SampleContextTracker
ClosedPublic

Authored by hoy on Jul 22 2021, 2:42 PM.

Details

Summary

Fixing a typo in SampleContextTracker to use debug name when debug linkage name is no present. This should only affect C programs.

Saw 0.6% perf win on Cinder which is mostly C code.

Diff Detail

Event Timeline

hoy created this revision.Jul 22 2021, 2:42 PM
hoy requested review of this revision.Jul 22 2021, 2:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2021, 2:42 PM
wenlei accepted this revision.Jul 22 2021, 2:52 PM

Good catch, thanks for the fix!

This revision is now accepted and ready to land.Jul 22 2021, 2:52 PM
wmi accepted this revision.Jul 22 2021, 2:55 PM

Good catch.

This revision was landed with ongoing or failed builds.Jul 22 2021, 4:44 PM
This revision was automatically updated to reflect the committed changes.