This is an archive of the discontinued LLVM Phabricator instance.

[LLDB][GUI] Resolve paths in file/directory fields
ClosedPublic

Authored by OmarEmaraDev on Jul 22 2021, 8:09 AM.

Details

Summary

This patch resolves the paths in the file/directory fields before
performing checks. Those checks are applied on the file system if
m_need_to_exist is true, so remote files can set this to false to avoid
performing host-side file system checks. Additionally, methods to get
a resolved and a direct file specs were added to be used by client code.

Diff Detail

Event Timeline

OmarEmaraDev created this revision.Jul 22 2021, 8:09 AM
OmarEmaraDev requested review of this revision.Jul 22 2021, 8:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2021, 8:09 AM
clayborg requested changes to this revision.Jul 23 2021, 6:06 PM
clayborg added inline comments.
lldb/source/Core/IOHandlerCursesGUI.cpp
1308

This is checking for a directory, not a file

This revision now requires changes to proceed.Jul 23 2021, 6:06 PM
OmarEmaraDev added inline comments.Jul 24 2021, 12:41 AM
lldb/source/Core/IOHandlerCursesGUI.cpp
1308

Not sure what you mean. It is setting an error if the file was in fact a directory,

clayborg accepted this revision.Jul 26 2021, 10:45 AM
clayborg added inline comments.
lldb/source/Core/IOHandlerCursesGUI.cpp
1308

Woops! You are right...

This revision is now accepted and ready to land.Jul 26 2021, 10:45 AM
This revision was landed with ongoing or failed builds.Jul 26 2021, 11:05 AM
This revision was automatically updated to reflect the committed changes.

@clayborg Did you check D106564? This is the last patch needed to do the rebase.

@clayborg Did you check D106564? This is the last patch needed to do the rebase.

Just committed that one and also the one that selects the right frame (https://reviews.llvm.org/D100243). We should be all up to date now.