[LLDB][GUI] Resolve paths in file/directory fields

[OmarEmaraDev]

Summary

This patch resolves the paths in the file/directory fields before
performing checks. Those checks are applied on the file system if
m_need_to_exist is true, so remote files can set this to false to avoid
performing host-side file system checks. Additionally, methods to get
a resolved and a direct file specs were added to be used by client code.

[clayborg]

lldb/source/Core/IOHandlerCursesGUI.cpp

1311

This is checking for a directory, not a file

[OmarEmaraDev]

lldb/source/Core/IOHandlerCursesGUI.cpp

1311

Not sure what you mean. It is setting an error if the file was in fact a directory,

[clayborg]

lldb/source/Core/IOHandlerCursesGUI.cpp

1311

Woops! You are right...

[OmarEmaraDev]

@clayborg Did you check D106564? This is the last patch needed to do the rebase.

[clayborg]

In D106553#2905223, @OmarEmaraDev wrote:

@clayborg Did you check D106564? This is the last patch needed to do the rebase.

Just committed that one and also the one that selects the right frame (https://reviews.llvm.org/D100243). We should be all up to date now.

lldb/source/Core/IOHandlerCursesGUI.cpp

FileFieldDelegate(const char *label, const char *content, bool need_to_exist,
       : TextFieldDelegate(label, content, required),
         m_need_to_exist(need_to_exist) {}
 
   void FieldDelegateExitCallback() override {
     TextFieldDelegate::FieldDelegateExitCallback();
     if (!IsSpecified())
       return;
 
-    FileSpec file(GetPath());
-    if (m_need_to_exist && !FileSystem::Instance().Exists(file)) {
+    if (!m_need_to_exist)
+      return;
+
+    FileSpec file = GetResolvedFileSpec();
+    if (!FileSystem::Instance().Exists(file)) {
       SetError("File doesn't exist!");
       return;
     }
     if (FileSystem::Instance().IsDirectory(file)) {
       SetError("Not a file!");
       return;
     }
   }
 
-  // Returns the path of the file.
+  FileSpec GetFileSpec() {
+    FileSpec file_spec(GetPath());
+    return file_spec;
+  }
+
+  FileSpec GetResolvedFileSpec() {
+    FileSpec file_spec(GetPath());
+    FileSystem::Instance().Resolve(file_spec);
+    return file_spec;
+  }
+
   const std::string &GetPath() { return m_content; }
 
 protected:
   bool m_need_to_exist;
 };
 
 class DirectoryFieldDelegate : public TextFieldDelegate {
 public:
   DirectoryFieldDelegate(const char *label, const char *content,
                          bool need_to_exist, bool required)
       : TextFieldDelegate(label, content, required),
         m_need_to_exist(need_to_exist) {}
 
   void FieldDelegateExitCallback() override {
     TextFieldDelegate::FieldDelegateExitCallback();
     if (!IsSpecified())
       return;
 
-    FileSpec file(GetPath());
-    if (m_need_to_exist && !FileSystem::Instance().Exists(file)) {
+    if (!m_need_to_exist)
+      return;
+
+    FileSpec file = GetResolvedFileSpec();
+    if (!FileSystem::Instance().Exists(file)) {
       SetError("Directory doesn't exist!");
       return;
     }
     if (!FileSystem::Instance().IsDirectory(file)) {
       SetError("Not a directory!");
       return;
     }
   }
 
-  // Returns the path of the file.
+  FileSpec GetFileSpec() {
+    FileSpec file_spec(GetPath());
+    return file_spec;
+  }
+
+  FileSpec GetResolvedFileSpec() {
+    FileSpec file_spec(GetPath());
+    FileSystem::Instance().Resolve(file_spec);
+    return file_spec;
+  }
+
   const std::string &GetPath() { return m_content; }
 
 protected:
   bool m_need_to_exist;
 };
 
 class BooleanFieldDelegate : public FieldDelegate {
 public: