This is an archive of the discontinued LLVM Phabricator instance.

[libc] Rename FEnv.h and refactor subsequent files
ClosedPublic

Authored by hedingarcia on Jul 21 2021, 11:40 AM.

Details

Summary

Because Windows's pathnames are not case sensitive,
to avoid include conflicts between our header file FEnv.h and the
one from the C Standard library, <fenv.h>, the prior file was renamed.
The motive for the relabel came to fix this include error in
TestHelpers.cpp since a conflict arose with a file in the same
directory when #include <fenv.h> was being used.

Diff Detail

Event Timeline

hedingarcia created this revision.Jul 21 2021, 11:40 AM
hedingarcia requested review of this revision.Jul 21 2021, 11:40 AM
aeubanks accepted this revision.Jul 21 2021, 11:46 AM
This revision is now accepted and ready to land.Jul 21 2021, 11:46 AM
sivachandra added a comment.EditedJul 21 2021, 1:19 PM

I think you should update CMakeLists.txt to reflect this renaming. Also, can you rename DummyFEnv.h to DummyFEnvImpl.h.

hedingarcia updated this revision to Diff 360589.EditedJul 21 2021, 1:48 PM

[libc] Updated CMakeLists.txt and renamed DummyFEnv.h

sivachandra accepted this revision.Jul 21 2021, 2:51 PM
sivachandra added inline comments.
libc/utils/FPUtil/CMakeLists.txt
8 ↗(On Diff #360589)

FEnvImpl.h?

[libc] Made a fix to CMakeLists.txt

hedingarcia marked an inline comment as done.Jul 21 2021, 5:05 PM
This revision was landed with ongoing or failed builds.Jul 21 2021, 5:08 PM
This revision was automatically updated to reflect the committed changes.
libc/utils/FPUtil/NearestIntegerOperations.h