Page MenuHomePhabricator

hedingarcia (Hedin García)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 16 2021, 11:48 AM (13 w, 5 d)

Recent Activity

Aug 5 2021

hedingarcia committed rGa9628e96ca5b: [libc] Add diff and perf targets for more math functions (authored by hedingarcia).
[libc] Add diff and perf targets for more math functions
Aug 5 2021, 10:57 AM
hedingarcia closed D107462: [libc] Add diff and perf targets for more math functions.
Aug 5 2021, 10:57 AM · Restricted Project
hedingarcia updated the summary of D107462: [libc] Add diff and perf targets for more math functions.
Aug 5 2021, 6:29 AM · Restricted Project
hedingarcia updated the diff for D107462: [libc] Add diff and perf targets for more math functions.

[libc] Added exp2f's diff and perf targets

Aug 5 2021, 6:27 AM · Restricted Project

Aug 4 2021

hedingarcia committed rZORG7d9ffd49c635: Add a libc x86_64 windows worker and a debug builder running on it (authored by hedingarcia).
Add a libc x86_64 windows worker and a debug builder running on it
Aug 4 2021, 9:31 AM
hedingarcia closed D106981: Add a libc x86_64 windows worker and a debug builder running on it.
Aug 4 2021, 9:31 AM
hedingarcia updated the diff for D107462: [libc] Add diff and perf targets for more math functions.

[libc] Fixed the format of certain comments

Aug 4 2021, 7:51 AM · Restricted Project
hedingarcia requested review of D107462: [libc] Add diff and perf targets for more math functions.
Aug 4 2021, 7:40 AM · Restricted Project

Aug 2 2021

hedingarcia updated the diff for D106981: Add a libc x86_64 windows worker and a debug builder running on it.

Addressed comments of the number of CPUs in the x86_64 machine

Aug 2 2021, 2:59 PM
hedingarcia committed rG2ab18d57d776: [libc] Add differential and performance targets for sqrtf (authored by hedingarcia).
[libc] Add differential and performance targets for sqrtf
Aug 2 2021, 12:30 PM
hedingarcia closed D107229: [libc] Add differential and performance targets for sqrtf.
Aug 2 2021, 12:30 PM · Restricted Project
hedingarcia updated the summary of D107229: [libc] Add differential and performance targets for sqrtf.
Aug 2 2021, 11:48 AM · Restricted Project
hedingarcia updated the summary of D107229: [libc] Add differential and performance targets for sqrtf.
Aug 2 2021, 11:48 AM · Restricted Project
hedingarcia updated the diff for D107229: [libc] Add differential and performance targets for sqrtf.

[libc] Fixed comments format

Aug 2 2021, 11:46 AM · Restricted Project
hedingarcia added a comment to D107229: [libc] Add differential and performance targets for sqrtf.

Yes, comparing the runtime of the sqrt functions from LLVM libc with the system libc:

functionperf - LLVM libcperf - MSVCRT
sqrtf - Windows44.05 sec (44051715500 ns)417.84 sec (417843359900 ns) = 6.96 mins
Aug 2 2021, 11:11 AM · Restricted Project

Jul 31 2021

hedingarcia requested review of D107229: [libc] Add differential and performance targets for sqrtf.
Jul 31 2021, 12:03 PM · Restricted Project

Jul 28 2021

hedingarcia requested review of D106981: Add a libc x86_64 windows worker and a debug builder running on it.
Jul 28 2021, 11:37 AM

Jul 27 2021

hedingarcia committed rG8baa87d91811: [libc] Enable MPFR library for math functions test (authored by hedingarcia).
[libc] Enable MPFR library for math functions test
Jul 27 2021, 1:40 PM
hedingarcia closed D106894: [libc] Enable MPFR library for math functions test.
Jul 27 2021, 1:40 PM · Restricted Project
hedingarcia added inline comments to D106894: [libc] Enable MPFR library for math functions test.
Jul 27 2021, 1:32 PM · Restricted Project
hedingarcia updated the diff for D106894: [libc] Enable MPFR library for math functions test.

[libc] Changed the description in README.md to suggested message

Jul 27 2021, 1:29 PM · Restricted Project
hedingarcia updated the diff for D106894: [libc] Enable MPFR library for math functions test.

[libc] Fixed the summary of LLVM_LIBC_MPFR_INSTALL_PATH and explained this option in README.md

Jul 27 2021, 12:53 PM · Restricted Project
hedingarcia added inline comments to D106894: [libc] Enable MPFR library for math functions test.
Jul 27 2021, 11:12 AM · Restricted Project
hedingarcia updated the diff for D106894: [libc] Enable MPFR library for math functions test.

[libc] Fixed message statement

Jul 27 2021, 10:58 AM · Restricted Project
hedingarcia updated the diff for D106894: [libc] Enable MPFR library for math functions test.

[libc] Added newline at end of files

Jul 27 2021, 10:51 AM · Restricted Project
hedingarcia requested review of D106894: [libc] Enable MPFR library for math functions test.
Jul 27 2021, 10:46 AM · Restricted Project

Jul 21 2021

hedingarcia committed rG049cfc464d17: [libc] Rename FEnv.h and refactor subsequent files (authored by hedingarcia).
[libc] Rename FEnv.h and refactor subsequent files
Jul 21 2021, 5:08 PM
hedingarcia closed D106470: [libc] Rename FEnv.h and refactor subsequent files.
Jul 21 2021, 5:08 PM · Restricted Project
hedingarcia updated the diff for D106470: [libc] Rename FEnv.h and refactor subsequent files.

[libc] Made a fix to CMakeLists.txt

Jul 21 2021, 5:04 PM · Restricted Project
hedingarcia updated the diff for D106470: [libc] Rename FEnv.h and refactor subsequent files.

[libc] Updated CMakeLists.txt and renamed DummyFEnv.h

Jul 21 2021, 1:48 PM · Restricted Project
hedingarcia requested review of D106470: [libc] Rename FEnv.h and refactor subsequent files.
Jul 21 2021, 11:40 AM · Restricted Project
hedingarcia abandoned D106177: [libc] Add math functions to Windows's entrypoints.
Jul 21 2021, 10:26 AM · Restricted Project
hedingarcia committed rGefa211526689: [libc] Include nextafter's functions to Windows's entrypoints (authored by hedingarcia).
[libc] Include nextafter's functions to Windows's entrypoints
Jul 21 2021, 6:28 AM
hedingarcia closed D106395: [libc] Include nextafter's functions to Windows's entrypoints.
Jul 21 2021, 6:28 AM · Restricted Project
hedingarcia committed rGf49f2e2d1f8d: [libc] Append math functions to Window's entrypoints (authored by hedingarcia).
[libc] Append math functions to Window's entrypoints
Jul 21 2021, 6:22 AM
hedingarcia closed D106391: [libc] Append math functions to Window's entrypoints.
Jul 21 2021, 6:22 AM · Restricted Project
hedingarcia committed rG137740ecedf1: [libc] Exclude few unused bits from x86 state for Windows (authored by hedingarcia).
[libc] Exclude few unused bits from x86 state for Windows
Jul 21 2021, 6:11 AM
hedingarcia closed D106386: [libc] Exclude few unused bits from x86 state for Windows.
Jul 21 2021, 6:11 AM · Restricted Project

Jul 20 2021

hedingarcia requested review of D106395: [libc] Include nextafter's functions to Windows's entrypoints.
Jul 20 2021, 1:58 PM · Restricted Project
hedingarcia requested review of D106391: [libc] Append math functions to Window's entrypoints.
Jul 20 2021, 1:10 PM · Restricted Project
hedingarcia updated the diff for D106386: [libc] Exclude few unused bits from x86 state for Windows.

Change macro directives to only evaluate if __WIN32 is undefined.

Jul 20 2021, 12:31 PM · Restricted Project
hedingarcia requested review of D106386: [libc] Exclude few unused bits from x86 state for Windows.
Jul 20 2021, 12:15 PM · Restricted Project

Jul 16 2021

hedingarcia updated the summary of D106177: [libc] Add math functions to Windows's entrypoints.
Jul 16 2021, 1:20 PM · Restricted Project
hedingarcia updated the diff for D106177: [libc] Add math functions to Windows's entrypoints.

[libc] Fixed commit description and ran clang-format

Jul 16 2021, 1:19 PM · Restricted Project
hedingarcia requested review of D106177: [libc] Add math functions to Windows's entrypoints.
Jul 16 2021, 12:19 PM · Restricted Project

Jul 15 2021

hedingarcia committed rGc97cb11efdfa: [libc] Relocate the closing directive of #ifdef (authored by hedingarcia).
[libc] Relocate the closing directive of #ifdef
Jul 15 2021, 1:25 PM
hedingarcia closed D106087: [libc] Relocate the closing directive of #ifdef.
Jul 15 2021, 1:24 PM · Restricted Project
hedingarcia updated the diff for D106087: [libc] Relocate the closing directive of #ifdef.

[libc] ran clang-format

Jul 15 2021, 1:06 PM · Restricted Project
hedingarcia updated subscribers of D106087: [libc] Relocate the closing directive of #ifdef.
Jul 15 2021, 11:34 AM · Restricted Project
hedingarcia requested review of D106087: [libc] Relocate the closing directive of #ifdef.
Jul 15 2021, 11:33 AM · Restricted Project

Jul 13 2021

hedingarcia committed rGa5a337e55ed2: [libc] Capture floating point encoding and arrange it sequentially in memory (authored by hedingarcia).
[libc] Capture floating point encoding and arrange it sequentially in memory
Jul 13 2021, 1:44 PM
hedingarcia closed D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.
Jul 13 2021, 1:44 PM · Restricted Project
hedingarcia committed rGd12a7f142e24: [libc] Add on float properties for precision floating point numbers in… (authored by hedingarcia).
[libc] Add on float properties for precision floating point numbers in…
Jul 13 2021, 1:16 PM
hedingarcia closed D105153: [libc] Add on float properties for precision floating point numbers in FloatProperties.h.
Jul 13 2021, 1:16 PM · Restricted Project
hedingarcia added inline comments to D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.
Jul 13 2021, 9:42 AM · Restricted Project
hedingarcia updated the summary of D105153: [libc] Add on float properties for precision floating point numbers in FloatProperties.h.
Jul 13 2021, 7:58 AM · Restricted Project
hedingarcia updated the summary of D105153: [libc] Add on float properties for precision floating point numbers in FloatProperties.h.
Jul 13 2021, 7:58 AM · Restricted Project

Jul 12 2021

hedingarcia updated the diff for D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.

[libc] Changed the return type of getSign()

Jul 12 2021, 1:54 PM · Restricted Project
hedingarcia added a comment to D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.

Probably bool is better since the compiler can assume it's only 0 or 1.

Jul 12 2021, 1:45 PM · Restricted Project
hedingarcia updated the diff for D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.

[libc] Removed encoding/FPUIntType struct and renamed getExponent()

Jul 12 2021, 11:48 AM · Restricted Project
hedingarcia retitled D105561: [libc] Capture floating point encoding and arrange it sequentially in memory from [libc] Capture floating point encoding and arrange it sequentially in memory with structs to [libc] Capture floating point encoding and arrange it sequentially in memory.
Jul 12 2021, 11:39 AM · Restricted Project

Jul 9 2021

hedingarcia updated the diff for D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.

[libc] Rearranging alias declarations and removing asserts

Jul 9 2021, 10:55 AM · Restricted Project
hedingarcia retitled D105561: [libc] Capture floating point encoding and arrange it sequentially in memory from [libc] Creating a struct that captures floating point encoding and manually arranges it sequentially in memory to [libc] Capture floating point encoding and arrange it sequentially in memory with structs.
Jul 9 2021, 8:23 AM · Restricted Project
hedingarcia added inline comments to D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.
Jul 9 2021, 6:36 AM · Restricted Project
hedingarcia updated the diff for D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.

[libc] Fixing shift in getExponent() and setExponent()

Jul 9 2021, 6:27 AM · Restricted Project
hedingarcia updated the summary of D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.
Jul 9 2021, 6:19 AM · Restricted Project

Jul 8 2021

hedingarcia updated the summary of D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.
Jul 8 2021, 3:01 PM · Restricted Project
hedingarcia updated the summary of D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.
Jul 8 2021, 2:55 PM · Restricted Project
hedingarcia added inline comments to D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.
Jul 8 2021, 2:44 PM · Restricted Project
hedingarcia added inline comments to D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.
Jul 8 2021, 2:28 PM · Restricted Project
hedingarcia updated the diff for D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.

[libc] Fix of the patch, refactored FPBits.h to have template structs

Jul 8 2021, 2:11 PM · Restricted Project
hedingarcia retitled D105561: [libc] Capture floating point encoding and arrange it sequentially in memory from [libc] (WIP) Modify the struct that captures floating point encoding to have setters and getters to [libc] Creating a struct that captures floating point encoding and manually arranges it sequentially in memory .
Jul 8 2021, 9:37 AM · Restricted Project
hedingarcia updated the diff for D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.

Fixed error signaled when running the tests for LdExpTest.h by ensuring that the value passed to set mantissa
did not lead to overload to the exponent value in FPBits.h and LongDoubleBitsX86.h.
Added asserts to detect those unintentional overflows in setMantissa() and setExponent().

Jul 8 2021, 9:05 AM · Restricted Project
hedingarcia abandoned D105638: [libc] Modify the struct that captures floating point encoding to have setters and getters.
Jul 8 2021, 8:56 AM · Restricted Project
hedingarcia requested review of D105638: [libc] Modify the struct that captures floating point encoding to have setters and getters.
Jul 8 2021, 8:55 AM · Restricted Project

Jul 7 2021

hedingarcia updated the summary of D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.
Jul 7 2021, 10:19 AM · Restricted Project
hedingarcia requested review of D105561: [libc] Capture floating point encoding and arrange it sequentially in memory.
Jul 7 2021, 10:12 AM · Restricted Project

Jul 1 2021

hedingarcia updated the summary of D105153: [libc] Add on float properties for precision floating point numbers in FloatProperties.h.
Jul 1 2021, 9:47 AM · Restricted Project
hedingarcia updated the diff for D105153: [libc] Add on float properties for precision floating point numbers in FloatProperties.h.

[libc] Fix of the patch, eliminated the explicitBit member

Jul 1 2021, 9:44 AM · Restricted Project
hedingarcia updated the summary of D105153: [libc] Add on float properties for precision floating point numbers in FloatProperties.h.
Jul 1 2021, 8:28 AM · Restricted Project
hedingarcia updated the diff for D105153: [libc] Add on float properties for precision floating point numbers in FloatProperties.h.

[libc] Fix of the patch, redefining mantissaWidth for the 80-bit long double and other properties

Jul 1 2021, 8:27 AM · Restricted Project

Jun 30 2021

hedingarcia added inline comments to D105153: [libc] Add on float properties for precision floating point numbers in FloatProperties.h.
Jun 30 2021, 1:33 PM · Restricted Project
hedingarcia updated the diff for D105153: [libc] Add on float properties for precision floating point numbers in FloatProperties.h.

[libc] Fix of the patch, redefining bit mask so they become easier to maintain

Jun 30 2021, 1:23 PM · Restricted Project
hedingarcia updated the summary of D105153: [libc] Add on float properties for precision floating point numbers in FloatProperties.h.
Jun 30 2021, 9:55 AM · Restricted Project
hedingarcia updated the diff for D105153: [libc] Add on float properties for precision floating point numbers in FloatProperties.h.

[libc] Fix the patch alongside with the recommendations given by reviewers.

Jun 30 2021, 9:25 AM · Restricted Project

Jun 29 2021

hedingarcia requested review of D105153: [libc] Add on float properties for precision floating point numbers in FloatProperties.h.
Jun 29 2021, 2:28 PM · Restricted Project
hedingarcia abandoned D105140: Mofidy and add the floating properties of single, double, and quad precision floating point numbers in FloatProperties.h.
Jun 29 2021, 1:58 PM · Restricted Project
hedingarcia retitled D105140: Mofidy and add the floating properties of single, double, and quad precision floating point numbers in FloatProperties.h from [libc] Mofidy and add the floating properties of single, double, and quad precision floating point numbers in FloatProperties.h to Mofidy and add the floating properties of single, double, and quad precision floating point numbers in FloatProperties.h.
Jun 29 2021, 1:33 PM · Restricted Project
hedingarcia updated the summary of D105140: Mofidy and add the floating properties of single, double, and quad precision floating point numbers in FloatProperties.h.
Jun 29 2021, 1:23 PM · Restricted Project
hedingarcia retitled D105140: Mofidy and add the floating properties of single, double, and quad precision floating point numbers in FloatProperties.h from Modified and added floating properties to single, double, and quad precision floating point numbers. to [libc] Mofidy and add the floating properties of single, double, and quad precision floating point numbers in FloatProperties.h.
Jun 29 2021, 1:22 PM · Restricted Project
hedingarcia updated the diff for D105140: Mofidy and add the floating properties of single, double, and quad precision floating point numbers in FloatProperties.h.

[libc] Fix error message signaled by a static_assert in FloatProperties.h

Jun 29 2021, 12:51 PM · Restricted Project
hedingarcia requested review of D105140: Mofidy and add the floating properties of single, double, and quad precision floating point numbers in FloatProperties.h.
Jun 29 2021, 12:11 PM · Restricted Project