This is an archive of the discontinued LLVM Phabricator instance.

[yaml2obj] Do not write the string table if there is no string entry.
ClosedPublic

Authored by Esme on Jul 20 2021, 10:08 PM.

Details

Summary

This is a minor patch from James's comments in D105522.
I will add a test for this after "llvm-readobj --string-table" supports printing the size of string tables.

Diff Detail

Event Timeline

Esme created this revision.Jul 20 2021, 10:08 PM
Esme requested review of this revision.Jul 20 2021, 10:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2021, 10:08 PM
Higuoxing accepted this revision.Jul 21 2021, 8:09 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 21 2021, 8:09 AM
jhenderson accepted this revision.Jul 23 2021, 1:45 AM

LGTM. This makes sense to me.

This revision was landed with ongoing or failed builds.Jul 25 2021, 7:38 PM
This revision was automatically updated to reflect the committed changes.