This is an archive of the discontinued LLVM Phabricator instance.

Differential D106281

Disable benchmark tests on iOS
ClosedPublic

Authored by mtrofin on Jul 19 2021, 7:55 AM.

Details

Reviewers
DavidSpickett
azharudd
Commits
rT3f9724e85f51: Disable benchmark tests on iOS
Summary

This is a temporary build fix.

Diff Detail

Event Timeline

mtrofin created this revision.Jul 19 2021, 7:55 AM
Herald added subscribers: ChuanqiXu, mgorny. · View Herald TranscriptJul 19 2021, 7:55 AM
mtrofin requested review of this revision.Jul 19 2021, 7:55 AM
Harbormaster completed remote builds in B114863: Diff 359792.Jul 19 2021, 7:55 AM
mtrofin mentioned this in D106155: Reland "[benchmark] Re-enable building benchmark tests".Jul 19 2021, 7:56 AM
DavidSpickett added a comment.Jul 19 2021, 8:24 AM

Based on https://cmake.org/cmake/help/latest/command/option.html this should work fine.

I think you should do the same for cmake/caches/target-arm64-iphoneos-internal.cmake as well, though going by the name there's no public bot for it.

mtrofin updated this revision to Diff 359808.Jul 19 2021, 8:33 AM

same idea for the xxx-internal file

Harbormaster completed remote builds in B114875: Diff 359808.Jul 19 2021, 8:33 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 19 2021, 12:23 PM
Closed by commit rT3f9724e85f51: Disable benchmark tests on iOS (authored by mtrofin). · Explain Why
This revision was automatically updated to reflect the committed changes.
mtrofin added a commit: rT3f9724e85f51: Disable benchmark tests on iOS.

Revision Contents

Diff 359808

cmake/caches/target-arm64-iphoneos-internal.cmake

set(XCRUN_FLAGS --toolchain iOS --sdk iphoneos.internal) set(XCRUN_FLAGS --toolchain iOS --sdk iphoneos.internal)
set(CMAKE_OSX_ARCHITECTURES arm64 CACHE STRING "") set(CMAKE_OSX_ARCHITECTURES arm64 CACHE STRING "")
set(BENCHMARK_ENABLE_TESTING OFF)
include(${CMAKE_CURRENT_LIST_DIR}/util/xcode_sdk.cmake) include(${CMAKE_CURRENT_LIST_DIR}/util/xcode_sdk.cmake)

cmake/caches/target-arm64-iphoneos.cmake

set(XCRUN_FLAGS --toolchain iOS --sdk iphoneos) set(XCRUN_FLAGS --toolchain iOS --sdk iphoneos)
set(CMAKE_OSX_ARCHITECTURES arm64 CACHE STRING "") set(CMAKE_OSX_ARCHITECTURES arm64 CACHE STRING "")
set(BENCHMARK_ENABLE_TESTING OFF)
include(${CMAKE_CURRENT_LIST_DIR}/util/xcode_sdk.cmake) include(${CMAKE_CURRENT_LIST_DIR}/util/xcode_sdk.cmake)

cmake/caches/target-thumbv7s-iphoneos.cmake

set(XCRUN_FLAGS --toolchain iOS --sdk iphoneos) set(XCRUN_FLAGS --toolchain iOS --sdk iphoneos)
set(CMAKE_OSX_ARCHITECTURES thumbv7s CACHE STRING "") set(CMAKE_OSX_ARCHITECTURES thumbv7s CACHE STRING "")
set(BENCHMARK_ENABLE_TESTING OFF)
include(${CMAKE_CURRENT_LIST_DIR}/util/xcode_sdk.cmake) include(${CMAKE_CURRENT_LIST_DIR}/util/xcode_sdk.cmake)