This is an archive of the discontinued LLVM Phabricator instance.

[CSSPGO] Turn on iterative-BFI for CSSPGO
ClosedPublic

Authored by wenlei on Jul 16 2021, 5:10 PM.

Details

Summary

Iterative-BFI produces better count quality and performance when evaluated on internal benchmarks. Turning it on by default now for CSSPGO. We can consider turn it on by default for AutoFDO as well in the future.

Diff Detail

Event Timeline

wenlei created this revision.Jul 16 2021, 5:10 PM
wenlei requested review of this revision.Jul 16 2021, 5:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 16 2021, 5:10 PM
wlei accepted this revision.Jul 16 2021, 5:16 PM

LGTM, thanks!

llvm/lib/Transforms/IPO/SampleProfile.cpp
1808

Nit: default

This revision is now accepted and ready to land.Jul 16 2021, 5:16 PM
wenlei updated this revision to Diff 359500.Jul 16 2021, 5:20 PM

fix typo

hoy accepted this revision.Jul 16 2021, 5:21 PM

lgtm, thx.

This revision was landed with ongoing or failed builds.Jul 16 2021, 5:36 PM
This revision was automatically updated to reflect the committed changes.