This is an archive of the discontinued LLVM Phabricator instance.

Tests for: D100299: Be lazier about loading .dwo files
AbandonedPublic

Authored by jankratochvil on Jul 16 2021, 2:30 PM.

Details

Reviewers
Eric
dblaikie
Summary

Diff Detail

Event Timeline

jankratochvil created this revision.Jul 16 2021, 2:30 PM
jankratochvil requested review of this revision.Jul 16 2021, 2:30 PM
Eric added a comment.Jul 21 2021, 3:04 PM

Thank you for helping me with this! Do you want me to merge these changes into my own CL or do you want to check this in yourself?

Instead of echoing into .c files, can we write the tests as .c files? It seems to be a common pattern to use a single source as two sources by compiling twice with different -D flags and then linking; see for example Shell/SymbolFile/DWARF/x86/dwarf5-partial-index.cpp

@Eric yes, it would be better to merge it with your D100299.

Instead of echoing into .c files, can we write the tests as .c files? It seems to be a common pattern to use a single source as two sources by compiling twice with different -D flags and then linking;

I agree, thanks for catching that.

jankratochvil abandoned this revision.Jul 26 2021, 10:03 AM

It has been merged to D100299.