This is an archive of the discontinued LLVM Phabricator instance.

Differential D106065

[Clang] Add an empty builtins.h file.
ClosedPublic

Authored by stefanp on Jul 15 2021, 7:40 AM.

Details

Reviewers
nemanjai
lei
Group Reviewers
Restricted Project
Commits
rG0bf4b81d57b0: [Clang] Add an empty builtins.h file.
Summary

On Power PC some legacy compilers included a number of builtins in a
builtins.h header file. While this header file is not required to hold
builtins for clang some legacy code does try to include this file and so
this patch provides an empty version of that file.

Diff Detail

Unit TestsFailed

TimeTest
1,410 msx64 debian > MemProfiler-x86_64-linux.TestCases::test_new_load_store.cpp
2,440 msx64 debian > libarcher.critical::critical.c
2,490 msx64 debian > libarcher.critical::lock-nested.c
2,440 msx64 debian > libarcher.parallel::parallel-simple.c
2,550 msx64 debian > libarcher.races::critical-unrelated.c
View Full Test Results (18 Failed)

Event Timeline

stefanp created this revision.Jul 15 2021, 7:40 AM
Herald added a subscriber: mgorny. · View Herald TranscriptJul 15 2021, 7:40 AM
stefanp requested review of this revision.Jul 15 2021, 7:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2021, 7:40 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
stefanp added a reviewer: Restricted Project.Jul 15 2021, 7:41 AM
Harbormaster completed remote builds in B114232: Diff 358959.Jul 15 2021, 9:58 AM
nemanjai added inline comments.Jul 15 2021, 10:11 AM
clang/lib/Headers/builtins.h
8

Please describe the purpose of this header file in a comment here.

clang/test/Headers/builtins-header.c
1

Does this need something like REQUIRES: powerpc-registered-target?

stefanp updated this revision to Diff 359186.Jul 15 2021, 6:28 PM

Added comment to the builtins.h file.

stefanp marked an inline comment as not done.Jul 15 2021, 6:29 PM
stefanp added inline comments.
clang/test/Headers/builtins-header.c
1

I don't think so... but I could be wrong. I am testing this using the Power PC triple but in reality there is nothing specifically Power PC about this header file. I think that it can be included on any target.

Harbormaster completed remote builds in B114397: Diff 359186.Jul 15 2021, 7:03 PM
nemanjai accepted this revision.Jul 16 2021, 4:31 AM

LGTM.

This revision is now accepted and ready to land.Jul 16 2021, 4:31 AM
This revision was landed with ongoing or failed builds.Jul 16 2021, 10:50 AM
Closed by commit rG0bf4b81d57b0: [Clang] Add an empty builtins.h file. (authored by stefanp). · Explain Why
This revision was automatically updated to reflect the committed changes.
stefanp added a commit: rG0bf4b81d57b0: [Clang] Add an empty builtins.h file..

Revision Contents

PathSize
clang/
lib/
Headers/
1 line
12 lines
test/
Headers/
8 lines

Diff 358959

clang/lib/Headers/CMakeLists.txt

Show All 32 Linesset(files
avx512vlvp2intersectintrin.h avx512vlvp2intersectintrin.h
avx512vpopcntdqvlintrin.h avx512vpopcntdqvlintrin.h
avx512vnniintrin.h avx512vnniintrin.h
avx512vlvnniintrin.h avx512vlvnniintrin.h
avxintrin.h avxintrin.h
avxvnniintrin.h avxvnniintrin.h
bmi2intrin.h bmi2intrin.h
bmiintrin.h bmiintrin.h
builtins.h
__clang_cuda_builtin_vars.h __clang_cuda_builtin_vars.h
__clang_cuda_math.h __clang_cuda_math.h
__clang_cuda_cmath.h __clang_cuda_cmath.h
__clang_cuda_complex_builtins.h __clang_cuda_complex_builtins.h
__clang_cuda_device_functions.h __clang_cuda_device_functions.h
__clang_cuda_intrinsics.h __clang_cuda_intrinsics.h
__clang_cuda_libdevice_declares.h __clang_cuda_libdevice_declares.h
__clang_cuda_math_forward_declares.h __clang_cuda_math_forward_declares.h
▲ Show 20 Lines • Show All 202 Lines • Show Last 20 Lines

clang/lib/Headers/builtins.h

  • This file was added.
/*===---- builtins.h - Standard header for extra builtins -----------------===*\
*
* Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
* See https://llvm.org/LICENSE.txt for license information.
* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
*
\*===----------------------------------------------------------------------===*/
nemanjaiUnsubmitted
Not Done
ReplyInline Actions

Please describe the purpose of this header file in a comment here.

nemanjai: Please describe the purpose of this header file in a comment here.
#ifndef __BUILTINS_H
Lint: Pre-merge checks
Inline Actions

clang-tidy: warning: header guard does not follow preferred style [llvm-header-guard]
not useful

Lint: Pre-merge checks: clang-tidy: warning: header guard does not follow preferred style [llvm-header-guard] [[https…
#define __BUILTINS_H
#endif /* __BUILTINS_H */

clang/test/Headers/builtins-header.c

  • This file was added.
// RUN: %clang_cc1 -triple powerpc64-unknown-unknown -ffreestanding -emit-llvm -o - %s | FileCheck %s
nemanjaiUnsubmitted
Not Done
ReplyInline Actions

Does this need something like REQUIRES: powerpc-registered-target?

nemanjai: Does this need something like `REQUIRES: powerpc-registered-target`?
stefanpAuthorUnsubmitted
Not Done
ReplyInline Actions

I don't think so... but I could be wrong. I am testing this using the Power PC triple but in reality there is nothing specifically Power PC about this header file. I think that it can be included on any target.

stefanp: I don't think so... but I could be wrong. I am testing this using the Power PC triple but in…
// RUN: %clang_cc1 -triple powerpc64le-unknown-unknown -ffreestanding -emit-llvm -o - %s | FileCheck %s
#include <builtins.h>
// Verify that we can include <builtins.h>
// CHECK: target triple = "powerpc64