This is an archive of the discontinued LLVM Phabricator instance.

[Clang] Add an empty builtins.h file.
ClosedPublic

Authored by stefanp on Jul 15 2021, 7:40 AM.

Details

Reviewers
nemanjai
lei
Group Reviewers
Restricted Project
Commits
rG0bf4b81d57b0: [Clang] Add an empty builtins.h file.
Summary

On Power PC some legacy compilers included a number of builtins in a
builtins.h header file. While this header file is not required to hold
builtins for clang some legacy code does try to include this file and so
this patch provides an empty version of that file.

Diff Detail

Event Timeline

stefanp created this revision.Jul 15 2021, 7:40 AM
stefanp requested review of this revision.Jul 15 2021, 7:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2021, 7:40 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
stefanp added a reviewer: Restricted Project.Jul 15 2021, 7:41 AM
nemanjai added inline comments.Jul 15 2021, 10:11 AM
clang/lib/Headers/builtins.h
9

Please describe the purpose of this header file in a comment here.

clang/test/Headers/builtins-header.c
2

Does this need something like REQUIRES: powerpc-registered-target?

stefanp updated this revision to Diff 359186.Jul 15 2021, 6:28 PM

Added comment to the builtins.h file.

stefanp marked an inline comment as not done.Jul 15 2021, 6:29 PM
stefanp added inline comments.
clang/test/Headers/builtins-header.c
2

I don't think so... but I could be wrong. I am testing this using the Power PC triple but in reality there is nothing specifically Power PC about this header file. I think that it can be included on any target.

nemanjai accepted this revision.Jul 16 2021, 4:31 AM

LGTM.

This revision is now accepted and ready to land.Jul 16 2021, 4:31 AM
This revision was landed with ongoing or failed builds.Jul 16 2021, 10:50 AM
This revision was automatically updated to reflect the committed changes.