[llvm-readobj] Remove one-dash long options

[MaskRay]

Summary

llvm-readelf is a user-facing tool which emulates GNU readelf. Remove one-dash
long options which are not recognized by GNU style getopt_long. This ensures
long options cannot collide with grouped short options.

Note: the documentation (D63719)/help messages have recommended the double-dash
forms since LLVM 9.0.0.
llvm-readobj is intended as an internal tool which has some flexibility.
llvm-readelf/llvm-readobj use the same option parsing code and llvm-readobj's
one-dash long options aren't used.

[jhenderson]

Is there anything in the docs that needs updating, or has that all been taken care of now?

llvm/tools/llvm-readobj/Opts.td

4

I might be being dumb, but don't you need to remove the "-" from here too? Otherwise, many options will still allow a single-dash, as far as I can tell (e.g. -addrsig, -all etc).

[MaskRay]

address comment

the doc has recommended -- since D63719

[jhenderson]

Pre-merge tests are showing up several LLD failures due to this change now. Best run the tests again and fix. Otherwise, LGTM.

[MaskRay]

In D106037#2882451, @jhenderson wrote:

Pre-merge tests are showing up several LLD failures due to this change now. Best run the tests again and fix. Otherwise, LGTM.

Migrated the tests in 3c9d86f9515e2cdc57dd76095ab9099aa399f652

llvm/tools/llvm-readobj/Opts.td

 include "llvm/Option/OptParser.td"
 
 class F<string letter, string help> : Flag<["-"], letter>, HelpText<help>;
 class FF<string name, string help> : Flag<["--", "-"], name>, HelpText<help>;
 
 multiclass BB<string name, string help1, string help2> {
-  def NAME: Flag<["--", "-"], name>, HelpText<help1>;
-  def no_ # NAME: Flag<["--", "-"], "no-" # name>, HelpText<help2>;
+  def NAME: Flag<["--"], name>, HelpText<help1>;
+  def no_ # NAME: Flag<["--"], "no-" # name>, HelpText<help2>;
 }
 
 multiclass Eq<string name, string help> {
-  def NAME #_EQ : Joined<["--", "-"], name #"=">,
+  def NAME #_EQ : Joined<["--"], name #"=">,
                   HelpText<help>;
-  def : Separate<["--", "-"], name>, Alias<!cast<Joined>(NAME #_EQ)>;
+  def : Separate<["--"], name>, Alias<!cast<Joined>(NAME #_EQ)>;
 }
 
 def addrsig : FF<"addrsig", "Display address-significance table">;
 def all : FF<"all", "Equivalent to setting: --file-header, --program-headers, --section-headers, "
              "--symbols, --relocations, --dynamic-table, --notes, --version-info, --unwind, "
              "--section-groups and --histogram">;
 def arch_specific : FF<"arch-specific", "Display architecture-specific information">;
 def bb_addr_map : FF<"bb-addr-map", "Display the BB address map section">;