This is an archive of the discontinued LLVM Phabricator instance.

Differential D106003

[Bazel] Uniformly export all MLIR td files
ClosedPublic

Authored by GMNGeoffrey on Jul 14 2021, 11:32 AM.

Details

Reviewers
jpienaar
Commits
rG8461995d35a4: [Bazel] Uniformly export all MLIR td files
Summary

CMake would have no restrictions on this and the custom list is a pain
to maintain.

Diff Detail

Event Timeline

GMNGeoffrey created this revision.Jul 14 2021, 11:32 AM
Herald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald TranscriptJul 14 2021, 11:32 AM
GMNGeoffrey requested review of this revision.Jul 14 2021, 11:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2021, 11:32 AM
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
GMNGeoffrey edited the summary of this revision. (Show Details)Jul 14 2021, 11:34 AM
GMNGeoffrey added a reviewer: jpienaar.
jpienaar accepted this revision.Jul 14 2021, 11:47 AM

Thanks!

This revision is now accepted and ready to land.Jul 14 2021, 11:47 AM
GMNGeoffrey updated this revision to Diff 358686.Jul 14 2021, 11:58 AM
  • Restore export of InliningUtils.h
GMNGeoffrey updated this revision to Diff 358693.Jul 14 2021, 12:10 PM
  • Restore other header file exports
This revision was landed with ongoing or failed builds.Jul 14 2021, 12:19 PM
Closed by commit rG8461995d35a4: [Bazel] Uniformly export all MLIR td files (authored by GMNGeoffrey). · Explain Why
This revision was automatically updated to reflect the committed changes.
GMNGeoffrey added a commit: rG8461995d35a4: [Bazel] Uniformly export all MLIR td files.

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
mlir/
28 lines

Diff 358694

utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

Show All 19 Linesexports_files([
"run_lit.sh", "run_lit.sh",
]) ])
filegroup( filegroup(
name = "c_headers", name = "c_headers",
srcs = glob(["include/mlir-c/**/*"]), # <== i.e. match the entire tree srcs = glob(["include/mlir-c/**/*"]), # <== i.e. match the entire tree
) )
exports_files(glob(["include/**/*.td"]))
[ [
gentbl_cc_library( gentbl_cc_library(
name = name + "IncGen", name = name + "IncGen",
strip_include_prefix = "include", strip_include_prefix = "include",
tbl_outs = [ tbl_outs = [
( (
["-gen-op-interface-decls"], ["-gen-op-interface-decls"],
"include/mlir/IR/" + name + ".h.inc", "include/mlir/IR/" + name + ".h.inc",
▲ Show 20 Lines • Show All 6,449 Lines • ▼ Show 20 Lines deps = [
":MathDialect", ":MathDialect",
":Pass", ":Pass",
":StandardOps", ":StandardOps",
":Transforms", ":Transforms",
], ],
) )
exports_files([ exports_files([
"include/mlir/Bindings/Python/Attributes.td",
"include/mlir/Dialect/DLTI/DLTIBase.td",
"include/mlir/Dialect/LLVMIR/LLVMOpBase.td",
"include/mlir/Dialect/Linalg/IR/LinalgOps.td",
"include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td",
"include/mlir/Dialect/Shape/IR/ShapeBase.td",
"include/mlir/Dialect/Shape/IR/ShapeOps.td",
"include/mlir/Dialect/StandardOps/IR/Ops.td",
"include/mlir/Dialect/Vector/VectorOps.td",
"include/mlir/Dialect/X86Vector/X86Vector.td",
"include/mlir/IR/OpAsmInterface.td",
"include/mlir/IR/OpBase.td",
"include/mlir/IR/RegionKindInterface.td",
"include/mlir/IR/SymbolInterfaces.td",
"include/mlir/IR/TensorEncoding.td",
"include/mlir/Interfaces/CallInterfaces.h", "include/mlir/Interfaces/CallInterfaces.h",
"include/mlir/Interfaces/CallInterfaces.td",
"include/mlir/Interfaces/CastInterfaces.h", "include/mlir/Interfaces/CastInterfaces.h",
"include/mlir/Interfaces/CastInterfaces.td",
"include/mlir/Interfaces/ControlFlowInterfaces.h", "include/mlir/Interfaces/ControlFlowInterfaces.h",
"include/mlir/Interfaces/ControlFlowInterfaces.td",
"include/mlir/Interfaces/CopyOpInterface.td",
"include/mlir/Interfaces/DataLayoutInterfaces.td",
"include/mlir/Interfaces/InferTypeOpInterface.td",
"include/mlir/Interfaces/LoopLikeInterface.td",
"include/mlir/Interfaces/SideEffectInterfaceBase.td",
"include/mlir/Interfaces/SideEffectInterfaces.td",
"include/mlir/Interfaces/VectorInterfaces.td",
"include/mlir/Interfaces/ViewLikeInterface.td",
"include/mlir/Transforms/InliningUtils.h", "include/mlir/Transforms/InliningUtils.h",
]) ])
td_library( td_library(
name = "MathOpsTdFiles", name = "MathOpsTdFiles",
srcs = [ srcs = [
"include/mlir/Dialect/Math/IR/MathBase.td", "include/mlir/Dialect/Math/IR/MathBase.td",
"include/mlir/Dialect/Math/IR/MathOps.td", "include/mlir/Dialect/Math/IR/MathOps.td",
▲ Show 20 Lines • Show All 367 Lines • Show Last 20 Lines