This is an archive of the discontinued LLVM Phabricator instance.

Add more types to the LLVM dialect C API
ClosedPublic

Authored by apaszke on Jul 13 2021, 10:13 AM.

Details

Summary

This includes:

  • void type
  • array types
  • function types
  • literal (unnamed) struct types

Diff Detail

Event Timeline

apaszke created this revision.Jul 13 2021, 10:13 AM
apaszke requested review of this revision.Jul 13 2021, 10:13 AM
apaszke updated this revision to Diff 358330.Jul 13 2021, 10:27 AM

Swapped the argument order to be more consistent with other APIs

ftynse accepted this revision.Jul 13 2021, 11:41 AM
ftynse added inline comments.
mlir/test/CAPI/llvm.c
57

Nit: did you forget the trailing 1 for the equality check?

63

Ditto.

This revision is now accepted and ready to land.Jul 13 2021, 11:41 AM
jpienaar accepted this revision.Jul 13 2021, 11:49 AM
apaszke updated this revision to Diff 358379.Jul 13 2021, 11:53 AM
apaszke marked 2 inline comments as done.

Add missing CHECK suffixes

This revision was automatically updated to reflect the committed changes.