This is an archive of the discontinued LLVM Phabricator instance.

Renames google_benchmark BUILD files to BUILD.bazel.
AbandonedPublic

Authored by ldionne on Jul 13 2021, 4:15 AM.

Details

Reviewers
bgraur
lebedev.ri
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

bgraur created this revision.Jul 13 2021, 4:15 AM
bgraur requested review of this revision.Jul 13 2021, 4:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2021, 4:15 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested changes to this revision.Jul 13 2021, 7:33 AM
ldionne added a subscriber: ldionne.

Just curious -- why is that needed? Is it not possible to make this change upstream? Otherwise, we'll have to do the same thing again when we update Google Benchmark next.

This revision now requires changes to proceed.Jul 13 2021, 7:33 AM
bgraur accepted this revision.Jul 13 2021, 7:55 AM

Just curious -- why is that needed? Is it not possible to make this change upstream? Otherwise, we'll have to do the same thing again when we update Google Benchmark next.

All bazel build files in LLVM have the ".bazel" suffix. It would be nice to keep this consistent.
I've spoken with the the Google benchmark maintainer to also update that repository -- they're looking into it.

lebedev.ri resigned from this revision.Jan 12 2023, 4:50 PM

This review seems to be stuck/dead, consider abandoning if no longer relevant.

Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 4:50 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
ldionne commandeered this revision.Sep 7 2023, 8:50 AM
ldionne removed a reviewer: ldionne.

[Github PR transition cleanup]

We should do this by updating GoogleBenchmark to the latest upstream version -- we should not make changes to our downstream copy of it since it means we'll basically fork that third-party library.

Commandeering to close.

ldionne abandoned this revision.Sep 7 2023, 8:50 AM
libcxx/utils/google-benchmark/bindings/python/BUILD.bazel