Page MenuHomePhabricator

[libc++] Fix libc++ in C++03 mode on Clang ToT
AbandonedPublic

Authored by ldionne on Jul 9 2021, 9:46 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This is an attempt to fix libc++ in C++03 mode after http://llvm.org/D104500,
which removed implicit move as an extension in C++03.

Diff Detail

Unit TestsFailed

TimeTest
460 mslibcxx CI C++03 > libcxx-trunk-shared.libcxx/memory/trivial_abi::unique_ptr_ret.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++-tot /home/libcxx-builder/.buildkite-agent/builds/f11afa4d9166-1/llvm-project/libcxx-ci/libcxx/test/libcxx/memory/trivial_abi/unique_ptr_ret.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -isystem /home/libcxx-builder/.buildkite-agent/builds/f11afa4d9166-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/f11afa4d9166-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -D_LIBCPP_ABI_ENABLE_UNIQUE_PTR_TRIVIAL_ABI -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/f11afa4d9166-1/llvm-project/libcxx-ci/build/generic-cxx03/lib -lc++ -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/f11afa4d9166-1/llvm-project/libcxx-ci/build/generic-cxx03/lib -pthread -o /home/libcxx-builder/.buildkite-agent/builds/f11afa4d9166-1/llvm-project/libcxx-ci/build/generic-cxx03/projects/libcxx/libcxx/memory/trivial_abi/Output/unique_ptr_ret.pass.cpp.dir/t.tmp.exe

Event Timeline

ldionne created this revision.Jul 9 2021, 9:46 AM
ldionne requested review of this revision.Jul 9 2021, 9:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2021, 9:46 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 357552.Jul 9 2021, 9:57 AM

Force the use of Clang ToT

ldionne updated this revision to Diff 357553.Jul 9 2021, 10:01 AM

CC => clang-tot instead of clang++-tot

ldionne updated this revision to Diff 357555.Jul 9 2021, 10:08 AM

Fix more instances

ldionne updated this revision to Diff 357562.Jul 9 2021, 10:17 AM

Fix more places

FWIW, IMO it's better to just wait for @mizvekov to fix trunk. There is certainly no intention of letting Clang trunk remain in this state for long, and certainly not to ship like this. So if you land D105712, at least please set a reminder to revert it in ~48 hours.

ldionne abandoned this revision.Jul 9 2021, 12:14 PM

FWIW, IMO it's better to just wait for @mizvekov to fix trunk. There is certainly no intention of letting Clang trunk remain in this state for long, and certainly not to ship like this. So if you land D105712, at least please set a reminder to revert it in ~48 hours.

Agreed.