Page MenuHomePhabricator

[libcxx][CI] Work around Arm buildkite failures
ClosedPublic

Authored by DavidSpickett on Jul 9 2021, 8:06 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGf8bef4734845: [libcxx][CI] Work around Arm buildkite failures
Summary

For reasons unknown, the build is now using compilers
from /usr/bin instead of /usr/local/bin which is where
we have our clang-12 aliases placed.

Diff Detail

Event Timeline

DavidSpickett created this revision.Jul 9 2021, 8:06 AM
DavidSpickett requested review of this revision.Jul 9 2021, 8:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2021, 8:06 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Working build:

[437/523] /usr/local/bin/c++  -DNDEBUG -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE...

Bad build:

[412/521] /usr/bin/c++  -DNDEBUG -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE ...
c++: error: unrecognized command line option '--target=armv7-linux-gnueabihf'

Our /usr/bin/ is a gcc which is A: not what we want and B: doesn't need a target option so it throws it out.

The recent libcxx changes seem fine but we did have a container restart about 12hr ago so this issue could have been lingering and brought up by using a fresh cmake config. I will find the actual reason.

@ldionne This fixes the Arm bots so if you want them green today you can merge this.

I'll find out what's really going on on Monday.

ldionne accepted this revision.Jul 9 2021, 9:14 AM

Thanks for the workaround. Let's try to find out what's going on and fix it properly once we've put the fire out.

This revision is now accepted and ready to land.Jul 9 2021, 9:14 AM
This revision was automatically updated to reflect the committed changes.

I found the issue and the next release of the buildkite agent will have a fix https://github.com/buildkite/agent/issues/1464.

I'll revert this once it's available. (your other uses of /usr/bin/cc for the other bots should continue to work it's just /usr/local that was effected)

I found the issue and the next release of the buildkite agent will have a fix https://github.com/buildkite/agent/issues/1464.

I'll revert this once it's available. (your other uses of /usr/bin/cc for the other bots should continue to work it's just /usr/local that was effected)

Thanks a lot for following up on this and fixing the Buildkite issue!