Page MenuHomePhabricator

[Polly][Isl] Use isl::*::ctx instead of isl::*::get_ctx. NFC
ClosedPublic

Authored by patacca on Jul 9 2021, 4:01 AM.

Details

Summary

This is part of an effort to reduce the differences between the custom C++ bindings used right now by polly in lib/External/isl/include/isl/isl-noxceptions.h and the official isl C++ interface.

Changes made:

Diff Detail

Event Timeline

patacca created this revision.Jul 9 2021, 4:01 AM
patacca updated this revision to Diff 357473.Jul 9 2021, 4:02 AM

Revert unrelated change

patacca published this revision for review.Jul 9 2021, 4:07 AM
patacca edited the summary of this revision. (Show Details)
patacca added a reviewer: Meinersbur.
patacca added a project: Restricted Project.
patacca edited the summary of this revision. (Show Details)
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2021, 4:08 AM
patacca retitled this revision from Use isl::*::ctx instead of isl::*::get_ctx to Use isl::*::ctx instead of isl::*::get_ctx. NFC.Jul 9 2021, 4:20 AM
patacca retitled this revision from Use isl::*::ctx instead of isl::*::get_ctx. NFC to [Polly]{Isl] Use isl::*::ctx instead of isl::*::get_ctx. NFC.Jul 9 2021, 4:23 AM
patacca retitled this revision from [Polly]{Isl] Use isl::*::ctx instead of isl::*::get_ctx. NFC to [Polly][Isl] Use isl::*::ctx instead of isl::*::get_ctx. NFC.
Meinersbur accepted this revision.Jul 9 2021, 9:31 AM

Could you add the reason for the added isl:: namespace to the commit message, like in this one:
https://github.com/patacca/isl/commit/b64e33c62d3fe7db506f6630f9e935b663f9c5a4

[suggestion] To avoid the "Lint: pre-merge checks" warnings in isl-noexceptions.h, you could make the generator emit // clang-format off (https://clang.llvm.org/docs/ClangFormatStyleOptions.html#disabling-formatting-on-a-piece-of-code)

This revision is now accepted and ready to land.Jul 9 2021, 9:31 AM
patacca edited the summary of this revision. (Show Details)Jul 9 2021, 11:01 AM
This revision was landed with ongoing or failed builds.Jul 9 2021, 12:14 PM
This revision was automatically updated to reflect the committed changes.
bmahjour removed a subscriber: bmahjour.Jul 12 2021, 6:38 AM