Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D105503

[ScalarEvolution] Make sure getMinusSCEV doesn't negate pointers.
ClosedPublic
Actions

Authored by efriedma on Jul 6 2021, 11:00 AM.

Details

Reviewers
reames
mkazantsev
nikic
lebedev.ri
Commits
rGf5603aa050ce: [ScalarEvolution] Make sure getMinusSCEV doesn't negate pointers.
Summary

Add a function removePointerBase that returns, essentially, S - getPointerBase(S). Use it in getMinusSCEV instead of multiplying a pointer by -1.

Diff Detail

Event Timeline

efriedma created this revision.Jul 6 2021, 11:00 AM
Herald added subscribers: javed.absar, hiraditya. · View Herald TranscriptJul 6 2021, 11:00 AM
efriedma requested review of this revision.Jul 6 2021, 11:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2021, 11:00 AM
Harbormaster completed remote builds in B112661: Diff 356780.Jul 6 2021, 11:35 AM
efriedma added a child revision: D105510: [ScalarEvolution] Strictly enforce pointer/int type rules..Jul 6 2021, 1:27 PM
mkazantsev added inline comments.Jul 7 2021, 1:19 AM
llvm/lib/Analysis/ScalarEvolution.cpp
4163

I guess you forgot to modify ops somewhere.

mkazantsev accepted this revision.Jul 7 2021, 1:20 AM

Oh sorry, I missed how it happened. LGTM :)

This revision is now accepted and ready to land.Jul 7 2021, 1:20 AM
Closed by commit rGf5603aa050ce: [ScalarEvolution] Make sure getMinusSCEV doesn't negate pointers. (authored by efriedma). · Explain WhyJul 7 2021, 10:27 AM
This revision was automatically updated to reflect the committed changes.
efriedma added a commit: rGf5603aa050ce: [ScalarEvolution] Make sure getMinusSCEV doesn't negate pointers..

Revision Contents
Changeset List

PathSize
llvm/
lib/
Analysis/
37 lines

Diff 356993

View Options

llvm/lib/Analysis/ScalarEvolution.cpp

Loading...