Page MenuHomePhabricator

[Polly][Isl] Use isl::union_set::unite() instead of isl::union_set::add_set(). NFC
ClosedPublic

Authored by patacca on Jul 5 2021, 11:54 AM.

Details

Summary

This is part of an effort to reduce the differences between the custom C++ bindings used right now by polly in lib/External/isl/include/isl/isl-noxceptions.h and the official isl C++ interface.

Changes made:

Depends on D104994

Diff Detail

Event Timeline

patacca created this revision.Jul 5 2021, 11:54 AM
patacca published this revision for review.Jul 5 2021, 11:58 AM
patacca edited the summary of this revision. (Show Details)
patacca added a reviewer: Meinersbur.
patacca added a project: Restricted Project.
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2021, 11:59 AM
bmahjour removed a subscriber: bmahjour.Jul 5 2021, 1:17 PM
Meinersbur added inline comments.Jul 5 2021, 4:33 PM
polly/lib/Analysis/DependenceInfo.cpp
195

Doesn't isl::set convert implicitly to isl::union_set?

Or is this due to some compiler error, e.g. ambiguous overload?

patacca retitled this revision from [Polly][Isl] Use isl::union_set::unite() instead of isl::union_set::add_set() to [Polly][Isl] Use isl::union_set::unite() instead of isl::union_set::add_set(). NFC.Jul 6 2021, 1:40 AM
patacca updated this revision to Diff 356635.Jul 6 2021, 2:17 AM

Use implicit conversion from isl::set to isl::union_set

I didn't think about it the first time.

patacca updated this revision to Diff 356667.Jul 6 2021, 3:33 AM

Rebase to main

This revision is now accepted and ready to land.Jul 6 2021, 10:48 AM