Page MenuHomePhabricator

[lldb/test] Fix failure caused by synthetic symbol name changes
ClosedPublic

Authored by mib on Jul 2 2021, 12:13 PM.

Details

Summary

This patch fixes a failure in TestFunctionStarts.py that appeared
following a change of implementation for synthetic symbol names:

https://reviews.llvm.org/D105160

The failure is caused because the previously mentioned patch removes the
object file basename from the generated synthetic symbol names to allow
them to be shared in the constant string pool.

Hence, that last check is not necessary anymore.

rdar://80092322

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>

Diff Detail

Event Timeline

mib requested review of this revision.Jul 2 2021, 12:13 PM
mib created this revision.
mib edited reviewers, added: jingham; removed: Jim.Jul 2 2021, 1:02 PM
JDevlieghere accepted this revision.Jul 2 2021, 1:16 PM

I see this is failing on GreenDragon. We should go ahead and land this and deal with potential post-commit review feedback if there is any. LGTM.

This revision is now accepted and ready to land.Jul 2 2021, 1:16 PM