[lldb/test] Fix failure caused by synthetic symbol name changes

[mib]

Summary

This patch fixes a failure in TestFunctionStarts.py that appeared
following a change of implementation for synthetic symbol names:

https://reviews.llvm.org/D105160

The failure is caused because the previously mentioned patch removes the
object file basename from the generated synthetic symbol names to allow
them to be shared in the constant string pool.

Hence, that last check is not necessary anymore.

rdar://80092322

Signed-off-by: Med Ismail Bennani <[e-mail]>

[JDevlieghere]

I see this is failing on GreenDragon. We should go ahead and land this and deal with potential post-commit review feedback if there is any. LGTM.

lldb/test/API/macosx/function-starts/TestFunctionStarts.py

def do_function_starts(self, in_memory):
         self.assertEqual(len(threads), 1, "Didn't hit my breakpoint.")
 
         # Our caller frame should have been stripped.  Make sure we made a synthetic symbol
         # for it:
         thread = threads[0]
         self.assertTrue(thread.num_frames > 1, "Couldn't backtrace.")
         name = thread.frame[1].GetFunctionName()
         self.assertTrue(name.startswith("___lldb_unnamed_symbol"))
-        self.assertTrue(name.endswith("$$StripMe"))