This is an archive of the discontinued LLVM Phabricator instance.

Differential D105336

[X86] Refine code of generating BB labels in Keylocker
ClosedPublic

Authored by xiangzhangllvm on Jul 2 2021, 1:29 AM.

Details

Reviewers
craig.topper
LuoYuanke
pengfei
Commits
rGa39bb960fc1e: [X86] Refine code of generating BB labels in Keylocker
Summary

Address Craig's suggestion to simplify the Keylocker code from https://reviews.llvm.org/D88398

Diff Detail

Event Timeline

xiangzhangllvm requested review of this revision.Jul 2 2021, 1:29 AM
xiangzhangllvm created this revision.
xiangzhangllvm edited the summary of this revision. (Show Details)
xiangzhangllvm mentioned this in D104766: [X86] Zero some outputs of Keylocker intrinsics in error case.Jul 2 2021, 1:31 AM
Harbormaster completed remote builds in B112162: Diff 356126.Jul 2 2021, 2:07 AM
craig.topper accepted this revision.Jul 2 2021, 9:11 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Jul 2 2021, 9:11 AM
xiangzhangllvm updated this revision to Diff 356414.Jul 4 2021, 6:14 PM

Refine clang format

xiangzhangllvm mentioned this in D88398: [X86] Support Intel Key Locker.Jul 4 2021, 6:16 PM
This revision was landed with ongoing or failed builds.Jul 4 2021, 6:31 PM
Closed by commit rGa39bb960fc1e: [X86] Refine code of generating BB labels in Keylocker (authored by xiangzhangllvm). · Explain Why
This revision was automatically updated to reflect the committed changes.
xiangzhangllvm added a commit: rGa39bb960fc1e: [X86] Refine code of generating BB labels in Keylocker.
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2021, 6:31 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B112387: Diff 356414.Jul 4 2021, 7:17 PM

Revision Contents

PathSize
clang/
lib/
CodeGen/
53 lines

Diff 356414

clang/lib/CodeGen/CGBuiltin.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 14,752 Lines • ▼ Show 20 Lines case X86::BI__builtin_ia32_encodekey256_u32: {
return Builder.CreateExtractValue(Call, 0); return Builder.CreateExtractValue(Call, 0);
} }
case X86::BI__builtin_ia32_aesenc128kl_u8: case X86::BI__builtin_ia32_aesenc128kl_u8:
case X86::BI__builtin_ia32_aesdec128kl_u8: case X86::BI__builtin_ia32_aesdec128kl_u8:
case X86::BI__builtin_ia32_aesenc256kl_u8: case X86::BI__builtin_ia32_aesenc256kl_u8:
case X86::BI__builtin_ia32_aesdec256kl_u8: { case X86::BI__builtin_ia32_aesdec256kl_u8: {
Intrinsic::ID IID; Intrinsic::ID IID;
StringRef StrNoErr, StrErr, StrEnd; StringRef BlockName;
switch (BuiltinID) { switch (BuiltinID) {
default: llvm_unreachable("Unexpected builtin"); default:
llvm_unreachable("Unexpected builtin");
case X86::BI__builtin_ia32_aesenc128kl_u8: case X86::BI__builtin_ia32_aesenc128kl_u8:
IID = Intrinsic::x86_aesenc128kl; IID = Intrinsic::x86_aesenc128kl;
StrNoErr = "aesenc128kl_no_error"; BlockName = "aesenc128kl";
StrErr = "aesenc128kl_error";
StrEnd = "aesenc128kl_end";
break; break;
case X86::BI__builtin_ia32_aesdec128kl_u8: case X86::BI__builtin_ia32_aesdec128kl_u8:
IID = Intrinsic::x86_aesdec128kl; IID = Intrinsic::x86_aesdec128kl;
StrNoErr = "aesdec128kl_no_error"; BlockName = "aesdec128kl";
StrErr = "aesdec128kl_error";
StrEnd = "aesdec128kl_end";
break; break;
case X86::BI__builtin_ia32_aesenc256kl_u8: case X86::BI__builtin_ia32_aesenc256kl_u8:
IID = Intrinsic::x86_aesenc256kl; IID = Intrinsic::x86_aesenc256kl;
StrNoErr = "aesenc256kl_no_error"; BlockName = "aesenc256kl";
StrErr = "aesenc256kl_error";
StrEnd = "aesenc256kl_end";
break; break;
case X86::BI__builtin_ia32_aesdec256kl_u8: case X86::BI__builtin_ia32_aesdec256kl_u8:
IID = Intrinsic::x86_aesdec256kl; IID = Intrinsic::x86_aesdec256kl;
StrNoErr = "aesdec256kl_no_error"; BlockName = "aesdec256kl";
StrErr = "aesdec256kl_error";
StrEnd = "aesdec256kl_end";
break; break;
} }
Value *Call = Builder.CreateCall(CGM.getIntrinsic(IID), {Ops[1], Ops[2]}); Value *Call = Builder.CreateCall(CGM.getIntrinsic(IID), {Ops[1], Ops[2]});
BasicBlock *NoError = createBasicBlock(StrNoErr, this->CurFn); BasicBlock *NoError =
BasicBlock *Error = createBasicBlock(StrErr, this->CurFn); createBasicBlock(BlockName + "_no_error", this->CurFn);
BasicBlock *End = createBasicBlock(StrEnd, this->CurFn); BasicBlock *Error = createBasicBlock(BlockName + "_error", this->CurFn);
BasicBlock *End = createBasicBlock(BlockName + "_end", this->CurFn);
Value *Ret = Builder.CreateExtractValue(Call, 0); Value *Ret = Builder.CreateExtractValue(Call, 0);
Value *Succ = Builder.CreateTrunc(Ret, Builder.getInt1Ty()); Value *Succ = Builder.CreateTrunc(Ret, Builder.getInt1Ty());
Value *Out = Builder.CreateExtractValue(Call, 1); Value *Out = Builder.CreateExtractValue(Call, 1);
Builder.CreateCondBr(Succ, NoError, Error); Builder.CreateCondBr(Succ, NoError, Error);
Builder.SetInsertPoint(NoError); Builder.SetInsertPoint(NoError);
Builder.CreateDefaultAlignedStore(Out, Ops[0]); Builder.CreateDefaultAlignedStore(Out, Ops[0]);
Builder.CreateBr(End); Builder.CreateBr(End);
Builder.SetInsertPoint(Error); Builder.SetInsertPoint(Error);
Constant *Zero = llvm::Constant::getNullValue(Out->getType()); Constant *Zero = llvm::Constant::getNullValue(Out->getType());
Builder.CreateDefaultAlignedStore(Zero, Ops[0]); Builder.CreateDefaultAlignedStore(Zero, Ops[0]);
Builder.CreateBr(End); Builder.CreateBr(End);
Builder.SetInsertPoint(End); Builder.SetInsertPoint(End);
return Builder.CreateExtractValue(Call, 0); return Builder.CreateExtractValue(Call, 0);
} }
case X86::BI__builtin_ia32_aesencwide128kl_u8: case X86::BI__builtin_ia32_aesencwide128kl_u8:
case X86::BI__builtin_ia32_aesdecwide128kl_u8: case X86::BI__builtin_ia32_aesdecwide128kl_u8:
case X86::BI__builtin_ia32_aesencwide256kl_u8: case X86::BI__builtin_ia32_aesencwide256kl_u8:
case X86::BI__builtin_ia32_aesdecwide256kl_u8: { case X86::BI__builtin_ia32_aesdecwide256kl_u8: {
Intrinsic::ID IID; Intrinsic::ID IID;
StringRef StrNoErr, StrErr, StrEnd; StringRef BlockName;
switch (BuiltinID) { switch (BuiltinID) {
case X86::BI__builtin_ia32_aesencwide128kl_u8: case X86::BI__builtin_ia32_aesencwide128kl_u8:
IID = Intrinsic::x86_aesencwide128kl; IID = Intrinsic::x86_aesencwide128kl;
StrNoErr = "aesencwide128kl_no_error"; BlockName = "aesencwide128kl";
StrErr = "aesencwide128kl_error";
StrEnd = "aesencwide128kl_end";
break; break;
case X86::BI__builtin_ia32_aesdecwide128kl_u8: case X86::BI__builtin_ia32_aesdecwide128kl_u8:
IID = Intrinsic::x86_aesdecwide128kl; IID = Intrinsic::x86_aesdecwide128kl;
StrNoErr = "aesdecwide128kl_no_error"; BlockName = "aesdecwide128kl";
StrErr = "aesdecwide128kl_error";
StrEnd = "aesdecwide128kl_end";
break; break;
case X86::BI__builtin_ia32_aesencwide256kl_u8: case X86::BI__builtin_ia32_aesencwide256kl_u8:
IID = Intrinsic::x86_aesencwide256kl; IID = Intrinsic::x86_aesencwide256kl;
StrNoErr = "aesencwide256kl_no_error"; BlockName = "aesencwide256kl";
StrErr = "aesencwide256kl_error";
StrEnd = "aesencwide256kl_end";
break; break;
case X86::BI__builtin_ia32_aesdecwide256kl_u8: case X86::BI__builtin_ia32_aesdecwide256kl_u8:
IID = Intrinsic::x86_aesdecwide256kl; IID = Intrinsic::x86_aesdecwide256kl;
StrNoErr = "aesdecwide256kl_no_error"; BlockName = "aesdecwide256kl";
StrErr = "aesdecwide256kl_error";
StrEnd = "aesdecwide256kl_end";
break; break;
} }
llvm::Type *Ty = FixedVectorType::get(Builder.getInt64Ty(), 2); llvm::Type *Ty = FixedVectorType::get(Builder.getInt64Ty(), 2);
Value *InOps[9]; Value *InOps[9];
InOps[0] = Ops[2]; InOps[0] = Ops[2];
for (int i = 0; i != 8; ++i) { for (int i = 0; i != 8; ++i) {
Value *Ptr = Builder.CreateConstGEP1_32(Ops[1], i); Value *Ptr = Builder.CreateConstGEP1_32(Ops[1], i);
InOps[i + 1] = Builder.CreateAlignedLoad(Ty, Ptr, Align(16)); InOps[i + 1] = Builder.CreateAlignedLoad(Ty, Ptr, Align(16));
} }
Value *Call = Builder.CreateCall(CGM.getIntrinsic(IID), InOps); Value *Call = Builder.CreateCall(CGM.getIntrinsic(IID), InOps);
BasicBlock *NoError = createBasicBlock(StrNoErr, this->CurFn); BasicBlock *NoError =
BasicBlock *Error = createBasicBlock(StrErr, this->CurFn); createBasicBlock(BlockName + "_no_error", this->CurFn);
BasicBlock *End = createBasicBlock(StrEnd, this->CurFn); BasicBlock *Error = createBasicBlock(BlockName + "_error", this->CurFn);
BasicBlock *End = createBasicBlock(BlockName + "_end", this->CurFn);
Value *Ret = Builder.CreateExtractValue(Call, 0); Value *Ret = Builder.CreateExtractValue(Call, 0);
Value *Succ = Builder.CreateTrunc(Ret, Builder.getInt1Ty()); Value *Succ = Builder.CreateTrunc(Ret, Builder.getInt1Ty());
Builder.CreateCondBr(Succ, NoError, Error); Builder.CreateCondBr(Succ, NoError, Error);
Builder.SetInsertPoint(NoError); Builder.SetInsertPoint(NoError);
for (int i = 0; i != 8; ++i) { for (int i = 0; i != 8; ++i) {
Value *Extract = Builder.CreateExtractValue(Call, i + 1); Value *Extract = Builder.CreateExtractValue(Call, i + 1);
▲ Show 20 Lines • Show All 3,343 Lines • Show Last 20 Lines