This is an archive of the discontinued LLVM Phabricator instance.

Differential D105227

[sanitizer] Don't tie builders with particular workers
ClosedPublic

Authored by vitalybuka on Jun 30 2021, 2:06 PM.

Details

Reviewers
gkistanova
morehouse
hctim
Commits
rZORGd37259ec73a4: [sanitizer] Don't tie builders with particular workers
Summary

This simplifies management of VMs. We don't need to care which
are online. If some is gone we will just see less frequent builds.

Diff Detail

Event Timeline

vitalybuka created this revision.Jun 30 2021, 2:06 PM
Herald added a reviewer: gkistanova. · View Herald TranscriptJun 30 2021, 2:06 PM
vitalybuka requested review of this revision.Jun 30 2021, 2:06 PM
Harbormaster completed remote builds in B111840: Diff 355678.Jun 30 2021, 2:06 PM
vitalybuka edited the summary of this revision. (Show Details)Jun 30 2021, 2:07 PM
vitalybuka added reviewers: morehouse, hctim.
hctim accepted this revision.Jun 30 2021, 2:11 PM

LGTM. Had no idea that zorg was phabricator-able.

This revision is now accepted and ready to land.Jun 30 2021, 2:11 PM
vitalybuka updated this revision to Diff 355685.Jun 30 2021, 2:21 PM

typo

Harbormaster completed remote builds in B111847: Diff 355685.Jun 30 2021, 2:21 PM
Closed by commit rZORGd37259ec73a4: [sanitizer] Don't tie builders with particular workers (authored by vitalybuka). · Explain WhyJun 30 2021, 8:55 PM
This revision was automatically updated to reflect the committed changes.
vitalybuka added a commit: rZORGd37259ec73a4: [sanitizer] Don't tie builders with particular workers.
vitalybuka added a reverting change: rZORGb899cd8edcb8: Revert "[sanitizer] Don't tie builders with particular workers".Jul 13 2021, 2:20 PM
ZijunZhao added a reverting change: D109558: Improved InformativeMailNotifier..Sep 9 2021, 6:27 PM
ZijunZhao added a reverting change: D109559: Improved InformativeMailNotifier..Sep 9 2021, 6:35 PM
ZijunZhao added a reverting change: D109561: Improved InformativeMailNotifier..Sep 9 2021, 6:42 PM
ZijunZhao added a reverting change: D109562: Improved InformativeMailNotifier..
ZijunZhao added a reverting change: D109563: Improved InformativeMailNotifier..Sep 9 2021, 6:45 PM
ZijunZhao added a reverting change: D109617: Improved InformativeMailNotifier..Sep 10 2021, 10:57 AM
DoyleLi added a reverting change: D158142: Improved InformativeMailNotifier..Aug 16 2023, 10:20 PM

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
65 lines

Diff 355678

buildbot/osuosl/master/config/builders.py

Show All 21 Lines
from zorg.buildbot.builders import XToolchainBuilder from zorg.buildbot.builders import XToolchainBuilder
from zorg.buildbot.builders import HtmlDocsBuilder from zorg.buildbot.builders import HtmlDocsBuilder
from zorg.buildbot.builders import DoxygenDocsBuilder from zorg.buildbot.builders import DoxygenDocsBuilder
reload(HtmlDocsBuilder) reload(HtmlDocsBuilder)
reload(DoxygenDocsBuilder) reload(DoxygenDocsBuilder)
# These are same VM so scheduler builds on any of them.
sanitizer_workers = [
"sanitizer-buildbot1",
"sanitizer-buildbot2",
"sanitizer-buildbot3",
"sanitizer-buildbot4",
"sanitizer-buildbot7",
"sanitizer-buildbot8",
]
all = [ all = [
# Clang fast builders. # Clang fast builders.
{'name' : "clang-x86_64-debian-fast", {'name' : "clang-x86_64-debian-fast",
'tags' : ["clang", "fast"], 'tags' : ["clang", "fast"],
'collapseRequests': False, 'collapseRequests': False,
▲ Show 20 Lines • Show All 1,151 Lines • ▼ Show 20 Lines 'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
'LD': 'lld', 'LD': 'lld',
'LD_LIBRARY_PATH': '/usr/lib64', 'LD_LIBRARY_PATH': '/usr/lib64',
})}, })},
# Sanitizer builders. # Sanitizer builders.
{'name' : "sanitizer-x86_64-linux", {'name' : "sanitizer-x86_64-linux",
'tags' : ["sanitizer"], 'tags' : ["sanitizer"],
'workernames' : [ 'workernames' : sanitizer_workers,
"sanitizer-buildbot1",
"sanitizer-buildbot2",
"sanitizer-buildbot4",
"sanitizer-buildbot8",
],
'builddir': "sanitizer-x86_64-linux", 'builddir': "sanitizer-x86_64-linux",
'factory' : SanitizerBuilder.getSanitizerBuildFactory()}, 'factory' : SanitizerBuilder.getSanitizerBuildFactory()},
{'name' : "sanitizer-x86_64-linux-fast", {'name' : "sanitizer-x86_64-linux-fast",
'tags' : ["sanitizer"], 'tags' : ["sanitizer"],
'workernames' : [ 'workernames' : sanitizer_workers,
"sanitizer-buildbot1",
"sanitizer-buildbot2",
"sanitizer-buildbot4",
"sanitizer-buildbot8",
],
'builddir': "sanitizer-x86_64-linux-fast", 'builddir': "sanitizer-x86_64-linux-fast",
'factory' : SanitizerBuilder.getSanitizerBuildFactory()}, 'factory' : SanitizerBuilder.getSanitizerBuildFactory()},
{'name' : "sanitizer-x86_64-linux-bootstrap-asan", {'name' : "sanitizer-x86_64-linux-bootstrap-asan",
'tags' : ["sanitizer"], 'tags' : ["sanitizer"],
'workernames' : [ 'workernames' : sanitizer_workers,
"sanitizer-buildbot3",
"sanitizer-buildbot2",
"sanitizer-buildbot4",
"sanitizer-buildbot8",
],
'builddir': "sanitizer-x86_64-linux-bootstrap-asan", 'builddir': "sanitizer-x86_64-linux-bootstrap-asan",
'factory' : SanitizerBuilder.getSanitizerBuildFactory()}, 'factory' : SanitizerBuilder.getSanitizerBuildFactory()},
{'name' : "sanitizer-x86_64-linux-bootstrap-ubsan", {'name' : "sanitizer-x86_64-linux-bootstrap-ubsan",
'tags' : ["sanitizer"], 'tags' : ["sanitizer"],
'workernames' : [ 'workernames' : sanitizer_workers,
"sanitizer-buildbot3",
"sanitizer-buildbot2",
"sanitizer-buildbot4",
"sanitizer-buildbot8",
],
'builddir': "sanitizer-x86_64-linux-bootstrap-ubsan", 'builddir': "sanitizer-x86_64-linux-bootstrap-ubsan",
'factory' : SanitizerBuilder.getSanitizerBuildFactory()}, 'factory' : SanitizerBuilder.getSanitizerBuildFactory()},
{'name' : "sanitizer-x86_64-linux-bootstrap-msan", {'name' : "sanitizer-x86_64-linux-bootstrap-msan",
'tags' : ["sanitizer"], 'tags' : ["sanitizer"],
'workernames' : [ 'workernames' : sanitizer_workers,
"sanitizer-buildbot7",
"sanitizer-buildbot2",
"sanitizer-buildbot4",
"sanitizer-buildbot8",
],
'builddir': "sanitizer-x86_64-linux-bootstrap-msan", 'builddir': "sanitizer-x86_64-linux-bootstrap-msan",
'factory' : SanitizerBuilder.getSanitizerBuildFactory()}, 'factory' : SanitizerBuilder.getSanitizerBuildFactory()},
{'name' : "sanitizer-x86_64-linux-autoconf", {'name' : "sanitizer-x86_64-linux-autoconf",
'tags' : ["sanitizer"], 'tags' : ["sanitizer"],
'workernames' : [ 'workernames' : sanitizer_workers,
"sanitizer-buildbot7",
"sanitizer-buildbot2",
"sanitizer-buildbot4",
"sanitizer-buildbot8",
],
'builddir': "sanitizer-x86_64-linux-autoconf", 'builddir': "sanitizer-x86_64-linux-autoconf",
'factory' : SanitizerBuilder.getSanitizerBuildFactory()}, 'factory' : SanitizerBuilder.getSanitizerBuildFactory()},
{'name' : "sanitizer-x86_64-linux-qemu", {'name' : "sanitizer-x86_64-linux-qemu",
'tags' : ["sanitizer"], 'tags' : ["sanitizer"],
'workernames' : [ 'workernames' : sanitizer_workers,
"sanitizer-buildbot7",
"sanitizer-buildbot2",
"sanitizer-buildbot4",
"sanitizer-buildbot8",
],
'builddir': "sanitizer-x86_64-linux-qemu", 'builddir': "sanitizer-x86_64-linux-qemu",
'factory' : SanitizerBuilder.getSanitizerBuildFactory()}, 'factory' : SanitizerBuilder.getSanitizerBuildFactory()},
{'name' : "sanitizer-x86_64-linux-fuzzer", {'name' : "sanitizer-x86_64-linux-fuzzer",
'tags' : ["sanitizer"], 'tags' : ["sanitizer"],
'workernames' : [ 'workernames' : sanitizer_workers,
"sanitizer-buildbot7",
"sanitizer-buildbot2",
"sanitizer-buildbot4",
"sanitizer-buildbot8",
],
'builddir': "sanitizer-x86_64-linux-fuzzer", 'builddir': "sanitizer-x86_64-linux-fuzzer",
'factory' : SanitizerBuilder.getSanitizerBuildFactory()}, 'factory' : SanitizerBuilder.getSanitizerBuildFactory()},
{'name' : "sanitizer-x86_64-linux-android", {'name' : "sanitizer-x86_64-linux-android",
'tags' : ["sanitizer"], 'tags' : ["sanitizer"],
'workernames' : ["sanitizer-buildbot6"], 'workernames' : ["sanitizer-buildbot6"],
'builddir': "sanitizer-x86_64-linux-android", 'builddir': "sanitizer-x86_64-linux-android",
'factory' : SanitizerBuilder.getSanitizerBuildFactory()}, 'factory' : SanitizerBuilder.getSanitizerBuildFactory()},
▲ Show 20 Lines • Show All 673 Lines • Show Last 20 Lines