Establish constants values and bit masks for the quad precision floating point numbers. Specifically for non x86, non-Windows x86, and Windows platform that are defined in PlatfromDefs.h. Also, added values that express the number of bits the exponent occupies in the single and double precision. This is in anticipation of the values that a struct that captures floating point encoding will use.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
For the subject, make it imperative, not past tense, e.g. "Modify and add ...", and don't end with a period
The description shouldn't be a copy of the subject
It should probably explain the changes a bit more in detail and why you did it. e.g. why did you start using PlatformDefs.h?
Which float properties are you adding?
https://chris.beams.io/posts/git-commit/ is a good read
Phabricator/arcanist is a bit weird when changing commit messages, you have to do it locally (git commit --amend) and in Edit Revision on Phabricator
Prefix subjects with [libc]. This change of yours, in its current state, is only fixing a copy paste error. So, the subject line can be something like:
[libc] Fix error message in a static_assert in FloatProperties.h
This is only an example, not a suggestion for this change as it seems to me like you will add much more shortly?