This is an archive of the discontinued LLVM Phabricator instance.

Mofidy and add the floating properties of single, double, and quad precision floating point numbers in FloatProperties.h
AbandonedPublic

Authored by hedingarcia on Jun 29 2021, 12:11 PM.

Details

Summary

Establish constants values and bit masks for the quad precision floating point numbers. Specifically for non x86, non-Windows x86, and Windows platform that are defined in PlatfromDefs.h. Also, added values that express the number of bits the exponent occupies in the single and double precision. This is in anticipation of the values that a struct that captures floating point encoding will use.

Diff Detail

Event Timeline

hedingarcia created this revision.Jun 29 2021, 12:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2021, 12:11 PM
hedingarcia requested review of this revision.Jun 29 2021, 12:11 PM
hedingarcia updated this revision to Diff 355338.EditedJun 29 2021, 12:51 PM

[libc] Fix error message signaled by a static_assert in FloatProperties.h

For the subject, make it imperative, not past tense, e.g. "Modify and add ...", and don't end with a period

The description shouldn't be a copy of the subject
It should probably explain the changes a bit more in detail and why you did it. e.g. why did you start using PlatformDefs.h?
Which float properties are you adding?

https://chris.beams.io/posts/git-commit/ is a good read

Phabricator/arcanist is a bit weird when changing commit messages, you have to do it locally (git commit --amend) and in Edit Revision on Phabricator

Prefix subjects with [libc]. This change of yours, in its current state, is only fixing a copy paste error. So, the subject line can be something like:

[libc] Fix error message in a static_assert in FloatProperties.h

This is only an example, not a suggestion for this change as it seems to me like you will add much more shortly?

hedingarcia retitled this revision from Modified and added floating properties to single, double, and quad precision floating point numbers. to [libc] Mofidy and add the floating properties of single, double, and quad precision floating point numbers in FloatProperties.h.Jun 29 2021, 1:22 PM
hedingarcia edited the summary of this revision. (Show Details)
hedingarcia edited the summary of this revision. (Show Details)Jun 29 2021, 1:23 PM
hedingarcia retitled this revision from [libc] Mofidy and add the floating properties of single, double, and quad precision floating point numbers in FloatProperties.h to Mofidy and add the floating properties of single, double, and quad precision floating point numbers in FloatProperties.h.Jun 29 2021, 1:33 PM
hedingarcia abandoned this revision.Jun 29 2021, 1:58 PM