[clang-tidy] Add -line-filter to run-clang-tidy.py

[bansan]

Summary

This patch allows the use of --line-filter in clang-tidy.py from run-clang-tidy.py

[xgupta]

Assuming this is your first patch, I add two reviewers for this patch who touch this file.

[bansan]

Right, this is my first patch. I based this one on https://reviews.llvm.org/D28334

[kbobyrev]

LGTM, thanks!

[kbobyrev]

Do you need help landing it?

[bansan]

@kbobyrev Yes please. I downloaded arc. I created a commit where last line is "Differential Revision: https://reviews.llvm.org/D104981".

I linked my github account to llvm's phabricator.

But when I arc land, I can't logon with my github username.

 STRATEGY  Merging with "squash" strategy, the default strategy.
 SOURCE  Landing the current branch, "main".
 ONTO REMOTE  Remote "origin" was selected by following tracking branches upstream to the closest remote.
 ONTO TARGET  Refs were selected by reading "arc.land.onto" configuration: main.
 INTO REMOTE  Will merge into remote "origin" by default, because this is the remote the change is landing onto.
 INTO TARGET  Will merge into target "main" by default, because this is the "onto" target.
 FETCH  Fetching "main" from remote "origin"...

  $   git fetch --no-tags --quiet -- origin main


 INTO COMMIT  Preparing merge into "main" from remote "origin", at commit "614b46e4dcab".
 LANDING  These changes will land:

  *   D104981 [clang-tidy] Add -line-filter to run-clang-tidy.py
          0610f15fab16  [clang-tidy] Add -line-filter to run-clang-tidy.py

 >>>  Land these changes? [y/N/?] y
 MERGING  0610f15fab16 [clang-tidy] Add -line-filter to run-clang-tidy.py
 MERGE  Attempting to rebase changes.
 DONE  Merge succeeded.
 PUSHING  Pushing changes to "origin".

  $   git push -- origin 6adf32fecc25:refs/heads/main

Username for 'https://github.com': bansan85
Password for 'https://[e-mail]':
remote: Permission to llvm/llvm-project.git denied to bansan85.
fatal: unable to access 'https://github.com/llvm/llvm-project.git/': The requested URL returned error: 403

 LOAD STATE  Restoring local state (to ref "main" at commit "0610f15fab16").
 USAGE EXCEPTION  Push failed! Fix the error and run "arc land" again.

I try to follow https://github.com/llvm/llvm-project/blob/main/llvm/docs/Phabricator.rst but I don't know what I missed.

Thanks,

[kbobyrev]

In D104981#2845005, @bansan wrote:

@kbobyrev Yes please. I downloaded arc. I created a commit where last line is "Differential Revision: https://reviews.llvm.org/D104981".

I linked my github account to llvm's phabricator.

But when I arc land, I can't logon with my github username.

 STRATEGY  Merging with "squash" strategy, the default strategy.
 SOURCE  Landing the current branch, "main".
 ONTO REMOTE  Remote "origin" was selected by following tracking branches upstream to the closest remote.
 ONTO TARGET  Refs were selected by reading "arc.land.onto" configuration: main.
 INTO REMOTE  Will merge into remote "origin" by default, because this is the remote the change is landing onto.
 INTO TARGET  Will merge into target "main" by default, because this is the "onto" target.
 FETCH  Fetching "main" from remote "origin"...

  $   git fetch --no-tags --quiet -- origin main


 INTO COMMIT  Preparing merge into "main" from remote "origin", at commit "614b46e4dcab".
 LANDING  These changes will land:

  *   D104981 [clang-tidy] Add -line-filter to run-clang-tidy.py
          0610f15fab16  [clang-tidy] Add -line-filter to run-clang-tidy.py

 >>>  Land these changes? [y/N/?] y
 MERGING  0610f15fab16 [clang-tidy] Add -line-filter to run-clang-tidy.py
 MERGE  Attempting to rebase changes.
 DONE  Merge succeeded.
 PUSHING  Pushing changes to "origin".

  $   git push -- origin 6adf32fecc25:refs/heads/main

Username for 'https://github.com': bansan85
Password for 'https://[e-mail]':
remote: Permission to llvm/llvm-project.git denied to bansan85.
fatal: unable to access 'https://github.com/llvm/llvm-project.git/': The requested URL returned error: 403

 LOAD STATE  Restoring local state (to ref "main" at commit "0610f15fab16").
 USAGE EXCEPTION  Push failed! Fix the error and run "arc land" again.

I try to follow https://github.com/llvm/llvm-project/blob/main/llvm/docs/Phabricator.rst but I don't know what I missed.

Thanks,

Landed the patch!

I think the problem is that you do not have the commit access yet. Here's how to get it: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

[bansan]

@kbobyrev Thanks, it's probably that. I thought I could send a patch/commit with my Phabricator account.

clang-tools-extra/clang-tidy/tool/run-clang-tidy.py

 def make_absolute(f, directory):
   if os.path.isabs(f):
     return f
   return os.path.normpath(os.path.join(directory, f))
 
 
 def get_tidy_invocation(f, clang_tidy_binary, checks, tmpdir, build_path,
                         header_filter, allow_enabling_alpha_checkers,
-                        extra_arg, extra_arg_before, quiet, config):
+                        extra_arg, extra_arg_before, quiet, config,
+                        line_filter):
   """Gets a command line for clang-tidy."""
   start = [clang_tidy_binary, '--use-color']
   if allow_enabling_alpha_checkers:
     start.append('-allow-enabling-analyzer-alpha-checkers')
   if header_filter is not None:
     start.append('-header-filter=' + header_filter)
+  if line_filter is not None:
+    start.append('-line-filter=' + line_filter)
   if checks:
     start.append('-checks=' + checks)
   if tmpdir is not None:
     start.append('-export-fixes')
     # Get a temporary file. We immediately close the handle so clang-tidy can
     # overwrite it.
     (handle, name) = tempfile.mkstemp(suffix='.yaml', dir=tmpdir)
     os.close(handle)

 def run_tidy(args, tmpdir, build_path, queue, lock, failed_files):
   """Takes filenames out of queue and runs clang-tidy on them."""
   while True:
     name = queue.get()
     invocation = get_tidy_invocation(name, args.clang_tidy_binary, args.checks,
                                      tmpdir, build_path, args.header_filter,
                                      args.allow_enabling_alpha_checkers,
                                      args.extra_arg, args.extra_arg_before,
-                                     args.quiet, args.config)
+                                     args.quiet, args.config, args.line_filter)
 
     proc = subprocess.Popen(invocation, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     output, err = proc.communicate()
     if proc.returncode != 0:
       failed_files.append(name)
     with lock:
       sys.stdout.write(' '.join(invocation) + '\n' + output.decode('utf-8'))
       if len(err) > 0:
parser.add_argument('-config', default=None,
                       'When the value is empty, clang-tidy will '
                       'attempt to find a file named .clang-tidy for '
                       'each source file in its parent directories.')
   parser.add_argument('-header-filter', default=None,
                       help='regular expression matching the names of the '
                       'headers to output diagnostics from. Diagnostics from '
                       'the main file of each translation unit are always '
                       'displayed.')
+  parser.add_argument('-line-filter', default=None,
+                      help='List of files with line ranges to filter the'
+                      'warnings.')
   if yaml:
     parser.add_argument('-export-fixes', metavar='filename', dest='export_fixes',
                         help='Create a yaml file to store suggested fixes in, '
                         'which can be applied with clang-apply-replacements.')
   parser.add_argument('-j', type=int, default=0,
                       help='number of tidy instances to be run in parallel.')
   parser.add_argument('files', nargs='*', default=['.*'],
                       help='files to be processed (regex on path)')