This is an archive of the discontinued LLVM Phabricator instance.

Differential D104922

[libomptarget][amdgpu] Build openmp for two more targets
ClosedPublic

Authored by JonChesterfield on Jun 25 2021, 8:12 AM.

Details

Reviewers
ronlieb
jdoerfert
jhuber6
Commits
rGf66b8fdc0a0b: [libomptarget][amdgpu] Build openmp for two more targets
Summary

[libomptarget][amdgpu] Build openmp for two more targets

The 4800U APU is a gfx902 and the MI100 accelerator is a gfx908.
Both numbers are listed in ROCT topology.c

Diff Detail

Event Timeline

JonChesterfield created this revision.Jun 25 2021, 8:12 AM
Herald added subscribers: guansong, t-tye, tpr and 5 others. · View Herald TranscriptJun 25 2021, 8:12 AM
JonChesterfield requested review of this revision.Jun 25 2021, 8:12 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJun 25 2021, 8:12 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, sstefan1, wdng. · View Herald Transcript
Harbormaster completed remote builds in B111007: Diff 354509.Jun 25 2021, 9:12 AM
JonChesterfield added a reviewer: jhuber6.Jun 25 2021, 10:52 AM
jhuber6 accepted this revision.Jun 25 2021, 11:01 AM

LGTM.
Works on my end, thanks.

This revision is now accepted and ready to land.Jun 25 2021, 11:01 AM
Closed by commit rGf66b8fdc0a0b: [libomptarget][amdgpu] Build openmp for two more targets (authored by JonChesterfield). · Explain WhyJun 25 2021, 11:02 AM
This revision was automatically updated to reflect the committed changes.
JonChesterfield added a commit: rGf66b8fdc0a0b: [libomptarget][amdgpu] Build openmp for two more targets.
JonChesterfield added a comment.Jun 25 2021, 5:36 PM

apologies for the duplication in the commit message

Revision Contents

PathSize
openmp/
libomptarget/
deviceRTLs/
amdgcn/
2 lines

Diff 354557

openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt

Show First 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
# for both in-tree and out-of-tree build # for both in-tree and out-of-tree build
if (NOT CMAKE_ARCHIVE_OUTPUT_DIRECTORY) if (NOT CMAKE_ARCHIVE_OUTPUT_DIRECTORY)
set(OUTPUTDIR ${CMAKE_CURRENT_BINARY_DIR}) set(OUTPUTDIR ${CMAKE_CURRENT_BINARY_DIR})
else() else()
set(OUTPUTDIR ${CMAKE_ARCHIVE_OUTPUT_DIRECTORY}) set(OUTPUTDIR ${CMAKE_ARCHIVE_OUTPUT_DIRECTORY})
endif() endif()
# create libraries # create libraries
set(mcpus gfx700 gfx701 gfx801 gfx803 gfx900 gfx906) set(mcpus gfx700 gfx701 gfx801 gfx803 gfx900 gfx902 gfx906 gfx908)
if (DEFINED LIBOMPTARGET_AMDGCN_GFXLIST) if (DEFINED LIBOMPTARGET_AMDGCN_GFXLIST)
set(mcpus ${LIBOMPTARGET_AMDGCN_GFXLIST}) set(mcpus ${LIBOMPTARGET_AMDGCN_GFXLIST})
endif() endif()
macro(add_cuda_bc_library) macro(add_cuda_bc_library)
set(cu_cmd ${CLANG_TOOL} set(cu_cmd ${CLANG_TOOL}
-xc++ -xc++
-c -c
▲ Show 20 Lines • Show All 57 Lines • Show Last 20 Lines