This is an archive of the discontinued LLVM Phabricator instance.

[MCA] Allow unlimited cycles in the timeline view
ClosedPublic

Authored by foad on Jun 24 2021, 4:01 AM.

Details

Summary

Change --max-timeline-cycles=0 to mean no limit on the number of cycles.
Use this in AMDGPU tests to show all instructions in the timeline view
instead of having it arbitrarily truncated.

Diff Detail

Event Timeline

foad created this revision.Jun 24 2021, 4:01 AM
foad requested review of this revision.Jun 24 2021, 4:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2021, 4:01 AM
foad added a comment.Jun 24 2021, 4:01 AM

Maybe unlimited width could be the default if stdout is not a tty? (And if it is a tty, the default could be to query its width?)

andreadb accepted this revision.Jun 24 2021, 4:35 AM

I only have a minor request. Otherwise it LGTM.

Could you please update the description of flag timeline-max-cycles in the llvm-mca docs before committing this patch?

Thanks
-Andrea

This revision is now accepted and ready to land.Jun 24 2021, 4:35 AM
foad updated this revision to Diff 354211.Jun 24 2021, 4:40 AM

Update docs.

andreadb accepted this revision.Jun 24 2021, 4:46 AM

Thanks! LGTM

This revision was landed with ongoing or failed builds.Jun 24 2021, 4:55 AM
This revision was automatically updated to reflect the committed changes.

+1 Good idea!